Set transport value using socket via_transport #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems we found an issue in case of using WSS transport. In that case 'Contact' header contains 'ws' value instead of 'wss'.
Contact: <sip:lovxxb@k87kr43mm.invalid;transport=WS;ob>It leads to call issue: 'Failed to set remote offer sdp: Called with SDP without DTLS fingerprint'
We suppose it is regression after implementation TransportType. Previously transport initialized using socket via_transport value ( ws | wss, depends on transport ). Currently it initializes using just TransportType enum value (ws, tcp), which does not cover the wss usage scenario.
024d0e8#diff-28c3dd474c00b015a64df65906a721293e92dba454e56886f0cb3de9701baf96L856-L861