Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audio_soloud codelab #2251

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Conversation

filiph
Copy link
Contributor

@filiph filiph commented Oct 17, 2024

Fixes and reenables CI for audio_soloud. Updates the minimum iOS and macOS deployment target to what pkg:flutter_soloud needs.

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@domesticmouse
Copy link
Contributor

Please fix up deprecated warnings:

info - lib/audio/audio_controller.dart:67:14 - 'addGlobalFilter' is deprecated and shouldn't be used. Please, to manage global filters use SoLoud.filters instead. Try replacing the use of the deprecated member with the replacement. - deprecated_member_use

@domesticmouse domesticmouse self-requested a review October 18, 2024 04:45
Copy link
Contributor

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix CI warnings

@filiph
Copy link
Contributor Author

filiph commented Oct 18, 2024

On it. I needed to fix another (runtime) issue in parallel, but all looks good now (after the codelab_build run finishes, fingers crossed).

Marco (@alnitak) and I also updated the codelab text: https://docs.google.com/document/d/1PZbGEXGbXUVsIpEMsSKMR_7b8ok5Gyl-fqFPmqOy_8w/edit

@filiph filiph changed the title [WIP] Fix audio_soloud codelab Fix audio_soloud codelab Oct 18, 2024
@filiph
Copy link
Contributor Author

filiph commented Oct 18, 2024

Ok, this is now ready for review.

The salient changes are https://github.com/flutter/codelabs/pull/2251/files/852f32f5c168029e650fe5fd2321785633386247..7c9df89e93905e168340f3d6728a00458395b286 (the last commit is just rerunning codelab_rebuild, which updates a bunch of random files).

@domesticmouse domesticmouse merged commit eb40664 into flutter:main Oct 18, 2024
10 checks passed
@domesticmouse
Copy link
Contributor

On it. I needed to fix another (runtime) issue in parallel, but all looks good now (after the codelab_build run finishes, fingers crossed).

Marco (@alnitak) and I also updated the codelab text: https://docs.google.com/document/d/1PZbGEXGbXUVsIpEMsSKMR_7b8ok5Gyl-fqFPmqOy_8w/edit

For googlers, please see cl/687449390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants