-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix audio_soloud codelab #2251
Fix audio_soloud codelab #2251
Conversation
Please fix up deprecated warnings: info - lib/audio/audio_controller.dart:67:14 - 'addGlobalFilter' is deprecated and shouldn't be used. Please, to manage global filters use SoLoud.filters instead. Try replacing the use of the deprecated member with the replacement. - deprecated_member_use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix CI warnings
On it. I needed to fix another (runtime) issue in parallel, but all looks good now (after the codelab_build run finishes, fingers crossed). Marco (@alnitak) and I also updated the codelab text: https://docs.google.com/document/d/1PZbGEXGbXUVsIpEMsSKMR_7b8ok5Gyl-fqFPmqOy_8w/edit |
Ok, this is now ready for review. The salient changes are https://github.com/flutter/codelabs/pull/2251/files/852f32f5c168029e650fe5fd2321785633386247..7c9df89e93905e168340f3d6728a00458395b286 (the last commit is just rerunning |
For googlers, please see cl/687449390 |
Fixes and reenables CI for
audio_soloud
. Updates the minimum iOS and macOS deployment target to whatpkg:flutter_soloud
needs.Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.