Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize chart pane controller code and prepare structure for offline mode. #7572

Merged
merged 107 commits into from
Apr 15, 2024

Conversation

polina-c
Copy link
Contributor

No description provided.

@polina-c polina-c requested review from bkonyi and a team as code owners April 12, 2024 18:12
@polina-c polina-c requested a review from kenzieschmoll April 12, 2024 19:46
@polina-c polina-c requested a review from kenzieschmoll April 12, 2024 21:46
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a couple nits

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2024
Copy link

auto-submit bot commented Apr 15, 2024

auto label is removed for flutter/devtools/7572, due to - The status or check suite devtools_app integration-test integration_dart2js - flutter - shard 3/3 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2024
@polina-c polina-c merged commit f175892 into flutter:master Apr 15, 2024
26 checks passed
@polina-c polina-c deleted the offline branch April 15, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App release-notes-not-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants