-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize chart pane controller code and prepare structure for offline mode. #7572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/devtools_app/lib/src/screens/memory/framework/memory_controller.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/framework/memory_controller.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/framework/memory_controller.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/framework/memory_controller.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/framework/screen_body.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/framework/offline_data/offline_data.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/framework/memory_controller.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/panes/diff/controller/diff_pane_controller.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/panes/profile/profile_pane_controller.dart
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/shared/heap/class_filter.dart
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/framework/memory_controller.dart
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/framework/memory_controller.dart
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/framework/offline_data/offline_data.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/framework/screen_body.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/shared/heap/class_filter.dart
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/framework/screen_body.dart
Outdated
Show resolved
Hide resolved
kenzieschmoll
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a couple nits
packages/devtools_app/lib/src/screens/memory/framework/memory_controller.dart
Outdated
Show resolved
Hide resolved
polina-c
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Apr 15, 2024
auto-submit
bot
removed
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Apr 15, 2024
auto label is removed for flutter/devtools/7572, due to - The status or check suite devtools_app integration-test integration_dart2js - flutter - shard 3/3 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
polina-c
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.