Skip to content

Commit

Permalink
Fix RecreateSKPs bot page sets II
Browse files Browse the repository at this point in the history
Both mobile SKPs of ebay/sfgate are not useful. We already have a desktop version of ebay. Create one for sfgate.

NoTry: true
Bug: skia:8653
Change-Id: I535c352d46d34500c2a8bdda12d406c58e16fd55
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203804
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
  • Loading branch information
rmistry authored and Skia Commit-Bot committed Mar 26, 2019
1 parent 16a8e99 commit 45d5f70
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 49 deletions.
40 changes: 0 additions & 40 deletions tools/skp/page_sets/skia_ebay_mobile.py

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -9,32 +9,32 @@
from telemetry.page import shared_page_state


class SkiaMobilePage(page_module.Page):
class SkiaDesktopPage(page_module.Page):

def __init__(self, url, page_set):
super(SkiaMobilePage, self).__init__(
super(SkiaDesktopPage, self).__init__(
url=url,
name=url,
page_set=page_set,
shared_page_state_class=shared_page_state.SharedMobilePageState)
self.archive_data_file = 'data/skia_sfgate_mobile.json'
shared_page_state_class=shared_page_state.SharedDesktopPageState)
self.archive_data_file = 'data/skia_sfgate_desktop.json'

def RunNavigateSteps(self, action_runner):
action_runner.Navigate(self.url)
action_runner.Wait(30)


class SkiaSfgateMobilePageSet(story.StorySet):
class SkiaSfgateDesktopPageSet(story.StorySet):
""" Pages designed to represent the median, not highly optimized web """

def __init__(self):
super(SkiaSfgateMobilePageSet, self).__init__(
archive_data_file='data/skia_sfgate_mobile.json')
super(SkiaSfgateDesktopPageSet, self).__init__(
archive_data_file='data/skia_sfgate_desktop.json')

urls_list = [
# go/skia-skps-3-2019
'http://www.sfgate.com/',
'http://www.sfgate.com/news/',
]

for url in urls_list:
self.AddStory(SkiaMobilePage(url, self))
self.AddStory(SkiaDesktopPage(url, self))

0 comments on commit 45d5f70

Please sign in to comment.