Skip to content

Commit

Permalink
Fix include path in fuchsia's analysis_options.yaml files (#57203)
Browse files Browse the repository at this point in the history
The old path doesn't exist.

`dart format` stumbles over this non-existent include.

`analysis_options.yaml` files that just imported something non-existent were deleted.

I am surprised that this never caused any other issues. Is this all dead code that isn't actually analyzed?
  • Loading branch information
goderbauer authored Dec 14, 2024
1 parent 2f66432 commit 4e4a430
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 19 deletions.
3 changes: 0 additions & 3 deletions ci/licenses_golden/excluded_files
Original file line number Diff line number Diff line change
Expand Up @@ -347,10 +347,8 @@
../../../flutter/shell/platform/embedder/platform_view_embedder_unittests.cc
../../../flutter/shell/platform/embedder/tests
../../../flutter/shell/platform/fuchsia/dart-pkg/fuchsia/README.md
../../../flutter/shell/platform/fuchsia/dart-pkg/fuchsia/analysis_options.yaml
../../../flutter/shell/platform/fuchsia/dart-pkg/fuchsia/pubspec.yaml
../../../flutter/shell/platform/fuchsia/dart-pkg/zircon/README.md
../../../flutter/shell/platform/fuchsia/dart-pkg/zircon/analysis_options.yaml
../../../flutter/shell/platform/fuchsia/dart-pkg/zircon/pubspec.yaml
../../../flutter/shell/platform/fuchsia/dart-pkg/zircon/test
../../../flutter/shell/platform/fuchsia/dart-pkg/zircon_ffi/pubspec.yaml
Expand All @@ -360,7 +358,6 @@
../../../flutter/shell/platform/fuchsia/dart_runner/kernel/libraries.json
../../../flutter/shell/platform/fuchsia/dart_runner/kernel/libraries.yaml
../../../flutter/shell/platform/fuchsia/dart_runner/tests
../../../flutter/shell/platform/fuchsia/dart_runner/vmservice/analysis_options.yaml
../../../flutter/shell/platform/fuchsia/dart_runner/vmservice/pubspec.yaml
../../../flutter/shell/platform/fuchsia/flutter/README.md
../../../flutter/shell/platform/fuchsia/flutter/accessibility_bridge_unittest.cc
Expand Down
5 changes: 0 additions & 5 deletions shell/platform/fuchsia/dart-pkg/fuchsia/analysis_options.yaml

This file was deleted.

5 changes: 0 additions & 5 deletions shell/platform/fuchsia/dart-pkg/zircon/analysis_options.yaml

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

include: ../../../tools/analysis_options.yaml
include: ../../../../../analysis_options.yaml
analyzer:
errors:
avoid_catches_without_on_clauses: ignore
Expand Down

0 comments on commit 4e4a430

Please sign in to comment.