[macOS] Fixed the platform view creation public method #30996
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| @@ -26,7 +26,7 @@ | |||
| * the Dart code, this will be null. Otherwise this will be the value sent from the Dart code as | |||
| * decoded by `createArgsCodec`. | |||
| */ | |||
| - (nonnull NSView*)createWithviewIdentifier:(int64_t)viewId arguments:(nullable id)args; | |||
| - (nonnull NSView*)createWithViewIdentifier:(int64_t)viewId arguments:(nullable id)args; | |||
|
|
|||
| /** | |||
| * Returns the `FlutterMessageCodec` for decoding the args parameter of `createWithFrame`. | |||
There was a problem hiding this comment.
Could you fix the create issue below as well, which is also breaking? Or is that for consistency with iOS?
There was a problem hiding this comment.
That was for consistency with iOS.
|
There are a couple of blockers for enabling platform views on macOS:
One of them is having automated tests for this. |
No description provided.