Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a python formatter #33797

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Adds a python formatter #33797

merged 2 commits into from
Jun 3, 2022

Conversation

zanderso
Copy link
Member

@zanderso zanderso commented Jun 3, 2022

This PR wires up a python formatter and formats all the flutter/engine python files according to Google open source style with a couple of small tweaks to be consistent with the Flutter recipes repo.

This is pre-work for adding a python linter, since pylint has opinions about formatting, which will be superseded by this actual formatting checker.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@zanderso zanderso force-pushed the try-yapf branch 3 times, most recently from 244dc42 to fc23516 Compare June 3, 2022 16:10
@skia-gold
Copy link

Gold has detected about 3 new digest(s) on patchset 2.
View them at https://flutter-engine-gold.skia.org/cl/github/33797

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #33797 at sha 8e03b78

@zanderso zanderso merged commit 9e0316d into flutter:main Jun 3, 2022
@zanderso zanderso deleted the try-yapf branch June 3, 2022 20:00
@zanderso zanderso mentioned this pull request Jun 3, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 3, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 4, 2022
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
* Adds a python formatter

* Apply format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants