Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland: Re-enable scenario tests on Android #34048

Merged
merged 4 commits into from
Jun 15, 2022

Conversation

blasten
Copy link

@blasten blasten commented Jun 14, 2022

Relands #33574

346adc0 addresses the comment in #33809

@blasten blasten requested review from zanderso and dnfield June 14, 2022 22:29
@blasten blasten changed the title Reland android tests Reland: Re-enable scenario tests on Android Jun 14, 2022
@blasten blasten force-pushed the reland_android_tests branch from 346adc0 to fd5c6bc Compare June 14, 2022 22:31
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skia-gold
Copy link

Gold has detected about 105 new digest(s) on patchset 3.
View them at https://flutter-engine-gold.skia.org/cl/github/34048

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #34048 at sha fd5c6bc

@skia-gold
Copy link

Gold has detected about 102 new digest(s) on patchset 4.
View them at https://flutter-engine-gold.skia.org/cl/github/34048

@skia-gold
Copy link

Gold has detected about 220 new digest(s) on patchset 5.
View them at https://flutter-engine-gold.skia.org/cl/github/34048

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #34048 at sha 6e06125

@blasten blasten force-pushed the reland_android_tests branch 3 times, most recently from 7521767 to deebbea Compare June 15, 2022 02:04
@blasten blasten force-pushed the reland_android_tests branch from deebbea to 3d099f6 Compare June 15, 2022 02:08
@blasten blasten added waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. and removed will affect goldens labels Jun 15, 2022
@fluttergithubbot fluttergithubbot merged commit 7db8c2b into flutter:main Jun 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants