Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reversed macOS trackpad rotation #36444

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Fix reversed macOS trackpad rotation #36444

merged 1 commit into from
Sep 28, 2022

Conversation

moffatman
Copy link
Contributor

macOS rotation values increase counterclockwise rather than the expected clockwise. So they have been inverted in polarity.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@ianthetechie ianthetechie mentioned this pull request Sep 27, 2022
Closed
9 tasks
@moffatman moffatman requested a review from dkwingsmt September 28, 2022 18:50
dkwingsmt
dkwingsmt approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moffatman moffatman added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 28, 2022
@auto-submit auto-submit bot merged commit d4db421 into flutter:main Sep 28, 2022
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
@moffatman @OlehSv
Fix reversed macOS trackpad rotation (flutter#36444)
415e990
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 28, 2022
@engine-flutter-autoroll
d4db421a9 Fix reversed macOS trackpad rotation (flutter/engine#36444)
47449d6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 28, 2022
@engine-flutter-autoroll
d4db421a9 Fix reversed macOS trackpad rotation (flutter/engine#36444)
5cf1356
dnfield pushed a commit to dnfield/engine that referenced this pull request Sep 30, 2022
@moffatman @dnfield
Fix reversed macOS trackpad rotation (flutter#36444)
72cd685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moffatman @dkwingsmt