[web] Make Canvaskit's malloc more useful #38130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
force-pushed
the
ck_malloc
branch
2 times, most recently
from
58198e8 to
5e7c3b7
Compare
yjbanov
approved these changes
Dec 14, 2022
|
|
||
| /// Allocates a [Float32List] backed by WASM memory, managed by | ||
| /// a [SkFloat32List]. | ||
| /// | ||
| /// To free the allocated array use [freeFloat32List]. | ||
| /// To free the allocated array use [freeList]. | ||
| SkFloat32List mallocFloat32List(int size) { |
There was a problem hiding this comment.
Let's document if size is in bytes or element count. Also, if it's the latter, then perhaps length is a more idiomatic name for the parameter (and I think sizeInBytes is more common for the other one).
There was a problem hiding this comment.
I'll check what CanvasKit calls the parameter.
| /// | ||
| /// The [list] is no longer usable after calling this function. | ||
| /// | ||
| /// Use this function to free lists owned by the engine. | ||
| @JS('window.flutterCanvasKit.Free') | ||
| external void freeFloat32List(SkFloat32List list); | ||
| external void freeList(_MallocObj list); |
There was a problem hiding this comment.
It's strange for a public function to take a private type. Can _MallocObj be public?
Also, nit: avoid abbreviations - MallocObject.
There was a problem hiding this comment.
Sure, I'll make it public.
As for the abbreviation, I used whatever name CanvasKit uses: https://github.com/google/skia/blob/0e95fd2482f8a456b2bcabf350efd51a042c3b97/modules/canvaskit/npm_build/types/index.d.ts#L786
| /// | ||
| /// The [list] is no longer usable after calling this function. | ||
| /// | ||
| /// Use this function to free lists owned by the engine. | ||
| @JS('window.flutterCanvasKit.Free') | ||
| external void freeFloat32List(SkFloat32List list); | ||
| external void freeList(_MallocObj list); |
There was a problem hiding this comment.
nit: do we need List in the name? In the future, we could extend the API to include other malloc-ed types, including non-List kinds, no?
There was a problem hiding this comment.
We don't need List in the name. I'll remove it.
mdebbar
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 38130, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
mdebbar
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 14, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 15, 2022
…117109) * 1a1b1feee Roll Skia from 537e1e8c1ca6 to 729ccbfb87bc (7 revisions) (flutter/engine#38277) * 3b18821e1 Roll Fuchsia Linux SDK from A0jnUUORf2LQu1z2V... to e2lfUFBW5ddtTZBbw... (flutter/engine#38280) * beb94ea2c Roll Skia from 729ccbfb87bc to 3171deabd88a (4 revisions) (flutter/engine#38279) * 8f9071ab9 Roll Fuchsia Mac SDK from FQQdl8AGAsALFniHl... to u-tC0QEGUT4xQ4KOo... (flutter/engine#38282) * aa78cd8d6 add link to website (flutter/engine#38273) * 955447b35 pylint all Python scripts under testing/ (flutter/engine#38268) * 3f22e1958 [web] correct float count in runtime effect (flutter/engine#38288) * 479bb736f Fix issues related to keyboard inset (flutter/engine#37719) * 6cd85616b [macOS] Refactor rendering infrastructure (flutter/engine#37789) * d1533d12b [web] Make Canvaskit's malloc more useful (flutter/engine#38130) * db5605ea7 Fix new `unnecessary_parenthesis` diagnostics. (flutter/engine#38291)
loic-sharma
pushed a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Dec 16, 2022
* [web] Make Canvaskit's malloc more useful * address review comments
loic-sharma
pushed a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Jan 3, 2023
* [web] Make Canvaskit's malloc more useful * address review comments
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#117109) * 1a1b1feee Roll Skia from 537e1e8c1ca6 to 729ccbfb87bc (7 revisions) (flutter/engine#38277) * 3b18821e1 Roll Fuchsia Linux SDK from A0jnUUORf2LQu1z2V... to e2lfUFBW5ddtTZBbw... (flutter/engine#38280) * beb94ea2c Roll Skia from 729ccbfb87bc to 3171deabd88a (4 revisions) (flutter/engine#38279) * 8f9071ab9 Roll Fuchsia Mac SDK from FQQdl8AGAsALFniHl... to u-tC0QEGUT4xQ4KOo... (flutter/engine#38282) * aa78cd8d6 add link to website (flutter/engine#38273) * 955447b35 pylint all Python scripts under testing/ (flutter/engine#38268) * 3f22e1958 [web] correct float count in runtime effect (flutter/engine#38288) * 479bb736f Fix issues related to keyboard inset (flutter/engine#37719) * 6cd85616b [macOS] Refactor rendering infrastructure (flutter/engine#37789) * d1533d12b [web] Make Canvaskit's malloc more useful (flutter/engine#38130) * db5605ea7 Fix new `unnecessary_parenthesis` diagnostics. (flutter/engine#38291)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open up Canvaskit's malloc to be used for other types of lists, not just float32.