Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] More sundry fixes to the Vulkan backend. #40244

Merged
merged 7 commits into from
Mar 13, 2023
Merged

[Impeller] More sundry fixes to the Vulkan backend. #40244

merged 7 commits into from
Mar 13, 2023

Conversation

chinmaygarde
Copy link
Member

@chinmaygarde chinmaygarde commented Mar 12, 2023 •
edited
Loading

  • Fix mip-map generation in unit-tests where the command buffer was not submitted.
  • Cleanup descriptor counts being always 1 in Vulkan code-gen.
  • Reworked capabilities. Platforms can add to the base capability set.
  • Vulkan backend picks between more available color and stencil formats.
  • Descriptor pools are dynamically sized.
  • Layout transitions are more explicit. Both allocated and swapchain images track their own layouts and redundant transitions are avoided.
  • Objects active in a pending command buffer are collected but the waits happen on a separate fence waiter. Thread is named "io.flutter.impeller.fence_waiter".
  • Added queue and command buffer instant markers for better traces.
  • Command pools and their buffers are now thread local. Fixes sync validation failure.
  • Debug reports are now more readable and command buffer and queue breadcrumbs will be displayed on a validation report.
  • Staging buffers are back.

Fixes flutter/flutter#121536
Fixes flutter/flutter#121627
Fixes flutter/flutter#121632
Fixes flutter/flutter#120499

@chinmaygarde
More sundry fixes to the Vulkan backend.
c3a94f3 
* Fix mip-map generation in unit-tests where the command buffer was not
  submitted.
* Cleanup descriptor counts being always 1 in Vulkan code-gen.
* Reworked capabilities. Platforms can add to the base capability set.
* Vulkan backend picks between more available color and stencil formats.
* Descriptor pools are dynamically sized.
* Layout transitions are more explicit. Both allocated and swapchain images
  track their own layouts and redundant transitions are avoided.
* Objects active in a pending command buffer are collected but the waits happen
  on a separate fence waiter. Thread is named
  "io.flutter.impeller.fence_waiter".
* Added queue and command buffer instant markers for better traces.
* Command pools and their buffers are now thread local. Fixes sync validation
  failure.
* Debug reports are now more readable and command buffer and queue breadcrumbs
  will be displayed on a validation report.
* Staging buffers are back.

Fixes flutter/flutter#121536
Fixes flutter/flutter#121627
Fixes flutter/flutter#121632
@chinmaygarde
Copy link
Member Author

I am still not done, see the context on the failures in Play/AiksTest.CanRenderClippedLayers/Vulkan in go/impeller-chat. But the latest rebase got me to conflicts with the device capabilities that I have reworked for Vulkan. So, I thought it best to commit what I have and continue with rest in smaller chunks.

@chinmaygarde chinmaygarde changed the title More sundry fixes to the Vulkan backend. [Impeller] More sundry fixes to the Vulkan backend. Mar 13, 2023
@chinmaygarde chinmaygarde self-assigned this Mar 13, 2023
jonahwilliams
jonahwilliams approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@chinmaygarde chinmaygarde mentioned this pull request Mar 13, 2023
Closed
@chinmaygarde
Copy link
Member Author

The remaining failures on presubs are because the iOS backend is running into flutter/flutter#120499 with the overriding mechanism not playing nicely with the update capabilities checks. Fixing that blocker now.

@chinmaygarde chinmaygarde mentioned this pull request Mar 13, 2023
Closed
@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2023
@auto-submit auto-submit bot merged commit ae979a8 into flutter:main Mar 13, 2023
@chinmaygarde chinmaygarde deleted the morevulkan branch March 13, 2023 06:54
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 13, 2023
@engine-flutter-autoroll
ae979a854 [Impeller] More sundry fixes to the Vulkan backend. (flutte…
2393ff0 
…r/engine#40244)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 13, 2023
@engine-flutter-autoroll
ae979a854 [Impeller] More sundry fixes to the Vulkan backend. (flutte…
739dc8b 
…r/engine#40244) (#122513)

Roll Flutter Engine from 57f7120ef923 to ae979a854eed (1 revision)
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Mar 13, 2023
flutter: ae979a854 [Impeller] More sundry fixes to the Vulkan backend. (
430f29c 
flutter/engine#40244) (#122513)

Commit: 739dc8b5a57c22d72257716873299ffa5082821e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2023
@engine-flutter-autoroll
739dc8b ae979a854 [Impeller] More sundry fixes to the Vulkan backend. (…
cde3de7 
…flutter/engine#40244) (flutter/flutter#122513)
zanderso added a commit that referenced this pull request Mar 13, 2023
@zanderso
Revert "[Impeller] More sundry fixes to the Vulkan backend. (#40244)"
68e36c1 
This reverts commit ae979a8.
@zanderso zanderso mentioned this pull request Mar 13, 2023
Merged
zanderso added a commit to flutter/flutter that referenced this pull request Mar 13, 2023
@zanderso
Revert "ae979a854 [Impeller] More sundry fixes to the Vulkan backend. (…
a8b3d9e 
…flutter/engine#40244) (#122513)"

This reverts commit 739dc8b.
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 13, 2023
@zanderso
Revert "ae979a854 [Impeller] More sundry fixes to the Vulkan backend. (…
2d1a5cd 
…flutter/engine#40244) (#122513)" (#122527)

Revert "Roll Flutter Engine from 57f7120ef923 to ae979a854eed (1 revision)"
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Mar 13, 2023
flutter: Revert "ae979a854 [Impeller] More sundry fixes to the Vulkan…
9d22ba4 
… backend. (flutter/engine#40244) (#122513)" (#122527)

Commit: 2d1a5cdc950648da598d73e33dcd947a34fa90d8
auto-submit bot pushed a commit that referenced this pull request Mar 13, 2023
@zanderso
Revert "[Impeller] More sundry fixes to the Vulkan backend. (#40244)" (…
650c6e3 
…#40247)

Revert "[Impeller] More sundry fixes to the Vulkan backend."
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2023
@engine-flutter-autoroll
739dc8b ae979a854 [Impeller] More sundry fixes to the Vulkan backend. (…
b7a432a 
…flutter/engine#40244) (flutter/flutter#122513)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2023
@engine-flutter-autoroll
2d1a5cd Revert "ae979a854 [Impeller] More sundry fixes to the Vulkan …
8704151 
…backend. (flutter/engine#40244) (#122513)" (flutter/flutter#122527)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 13, 2023
@engine-flutter-autoroll
ae979a854 [Impeller] More sundry fixes to the Vulkan backend. (flutte…
c4b4bf7 
…r/engine#40244)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2023
@engine-flutter-autoroll
739dc8b ae979a854 [Impeller] More sundry fixes to the Vulkan backend. (…
3cdada7 
…flutter/engine#40244) (flutter/flutter#122513)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2023
@engine-flutter-autoroll
2d1a5cd Revert "ae979a854 [Impeller] More sundry fixes to the Vulkan …
0cbaedb 
…backend. (flutter/engine#40244) (#122513)" (flutter/flutter#122527)
jonahwilliams added a commit to jonahwilliams/engine that referenced this pull request Mar 13, 2023
@jonahwilliams
Squashed commit of the following:
bd9cdb0 
commit db8dfbe
Author: jonahwilliams <jonahwilliams@google.com>
Date:   Mon Mar 13 10:44:36 2023 -0700

    update malioc diff

commit 0877a53
Merge: 04e8d80 7c5a9d5
Author: jonahwilliams <jonahwilliams@google.com>
Date:   Mon Mar 13 10:40:07 2023 -0700

    Merge branch 'master' of github.com:flutter/engine into uv_computation

commit 7c5a9d5
Author: Jackson Gardner <jacksongardner@google.com>
Date:   Mon Mar 13 09:54:22 2023 -0700

    Use plain Uint32List objects with the fragmenter APIs. (flutter#40239)

    Use plain Uint32List objects with the fragmenter APIs.

commit 04e8d80
Author: jonahwilliams <jonahwilliams@google.com>
Date:   Mon Mar 13 09:50:23 2023 -0700

    fix double divide and add test

commit 9b42cbc
Author: jonahwilliams <jonahwilliams@google.com>
Date:   Mon Mar 13 09:32:48 2023 -0700

    [impeller] implement GetPositionUVBuffer

commit 3d545ad
Author: Dan Field <dnfield@google.com>
Date:   Mon Mar 13 09:22:28 2023 -0700

    [Impeller][Compute] Fix visual issues with heart (flutter#40240)

commit 650c6e3
Author: Zachary Anderson <zanderso@users.noreply.github.com>
Date:   Mon Mar 13 08:45:38 2023 -0700

    Revert "[Impeller] More sundry fixes to the Vulkan backend. (flutter#40244)" (flutter#40247)

    Revert "[Impeller] More sundry fixes to the Vulkan backend."

commit 3ac895e
Author: Jonah Williams <jonahwilliams@google.com>
Date:   Mon Mar 13 08:42:13 2023 -0700

    [Impeller] support for foreground shaders on text (flutter#40193)

    [Impeller] support for foreground shaders on text

commit bb1ca8f
Author: Lasse R.H. Nielsen <lrn@google.com>
Date:   Mon Mar 13 13:43:04 2023 +0100

    Change `extends Iterator` to using `implements` (flutter#40175)

    The Dart 3.0 libraries will mark Iterator with the interface class modifier, which prevents extends. It will do so because the class has no implementation to inherit, and is only intended as an interface, which it is now possible to express.

    This should unblock relanding https://dart-review.googlesource.com/c/sdk/+/287760
    (Also working on disabling the class-modifiers experiment for Flutter dart: libraries, which was enabled along with the Dart SDK libraries, until the experiment can be intentionally turned back on.)

commit 24afaf9
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Mar 13 09:44:31 2023 +0000

    Bump github/codeql-action from 2.2.5 to 2.2.6 (flutter#40246)

    Bump github/codeql-action from 2.2.5 to 2.2.6

commit ae979a8
Author: Chinmay Garde <chinmaygarde@google.com>
Date:   Sun Mar 12 23:49:22 2023 -0700

    [Impeller] More sundry fixes to the Vulkan backend. (flutter#40244)

    [Impeller] More sundry fixes to the Vulkan backend.

commit 57f7120
Author: Zachary Anderson <zanderso@users.noreply.github.com>
Date:   Sat Mar 11 19:38:43 2023 -0800

    Add GN arguments that disable building host artifacts (flutter#40242)

commit 04e8d54
Author: Chris Bracken <chris@bracken.jp>
Date:   Sat Mar 11 12:49:59 2023 -0800

    [macOS] Forward mouseDown/Up to view controller (flutter#40241)

    This works around an AppKit bug in which mouseDown/mouseUp events are
    not correctly forwarded up the responder chain for views nested inside
    an NSPopover if (and only if) the macOS "Reduce Transparency"
    accessibility setting is enabled in the System Settings.

    When the above conditions are satisfied, the nested NSView receives the
    mouseDown:/mouseUp: call but if it delegates to the default
    implementation (implemented in NSResponder) mouseDown/mouseUp calls are
    triggered on containing views (in our case FlutterViewWrapper) but not
    triggered on the view controller and other responders in the responder
    chain until we an _NSPopoverWindow class is hit.

    A minimal AppKit-only (non-Flutter) repro shows this behaviour repros
    with even a minimal NSViewController implementation and an unmodified NSView.
    See: https://github.com/cbracken/PopoverRepro

    A radar has been filed with Apple and a copy posted to OpenRadar.
    See: http://www.openradar.me/FB12050037

    In order to work around this bug, we override mouseDown/mouseUp in the
    topmost containing view of FlutterView (in our case, FlutterViewWrapper)
    to have the behaviour documented as the default behaviour in
    NSResponder's mouseDown/mouseUp documentation. In otherwords, to simply
    forward the call to self.nextResponder.
    See: https://developer.apple.com/documentation/appkit/nsresponder/1524634-mousedown

    Because replicating the exact configuration of a FlutterView contained
    in an NSPopover and System Settings that have been modified to enable
    the "Reduce Transparency" setting is difficult and likely error-prone in
    infra, we instead simulate the bug by testing that even if NSResponder's
    mouseDown/mouseUp method are swizzled to no-op, these calls are
    correctly forwarded to the next responder in the chain.

    If, in the future Apple does fix this issue, this workaround can be
    removed once Flutter's minimum supported macOS SDK is at least the
    version that contains the fix.

    Issue: flutter/flutter#115015

commit c7894a6
Author: Dan Field <dnfield@google.com>
Date:   Fri Mar 10 16:39:04 2023 -0800

    Make the context current before accessing GL in MakeSkiaGpuImage (flutter#40208)

    Make the context current before accessing GL in MakeSkiaGpuImage

commit 7f25023
Author: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
Date:   Fri Mar 10 15:42:18 2023 -0800

    Revert "Make FlutterTest the default test font (flutter#40188)" (flutter#40237)

    This reverts commit 9270e3d.

commit 12f2fdf
Author: Yegor <yjbanov@google.com>
Date:   Fri Mar 10 14:46:06 2023 -0800

    Revert "[web] Access engine version to get correct gstatic URL (flutter#40194)" (flutter#40235)

    This reverts commit 161f759.

commit 3018843
Author: skia-flutter-autoroll <skia-flutter-autoroll@skia.org>
Date:   Fri Mar 10 17:44:48 2023 -0500

    Manual roll Dart SDK from 7240b35cc401 to c766fffb626e (9 revisions) (flutter#40233)

    Manual roll requested by asiva@google.com

    https://dart.googlesource.com/sdk.git/+log/7240b35cc401..c766fffb626e

    2023-03-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-322.0.dev
    2023-03-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-321.0.dev
    2023-03-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-320.0.dev
    2023-03-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-319.0.dev
    2023-03-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-318.0.dev
    2023-03-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-317.0.dev
    2023-03-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-316.0.dev
    2023-03-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-315.0.dev
    2023-03-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-314.0.dev

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter-engine
    Please CC aam@google.com,asiva@google.com,dart-vm-team@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
    is aware of the problem.

    To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit 220e867
Author: Zachary Anderson <zanderso@users.noreply.github.com>
Date:   Fri Mar 10 14:38:58 2023 -0800

    Roll buildroot to 287917d (flutter#40232)

    To pick up flutter/buildroot#691

commit c99baf2
Author: Jim Graham <flar@google.com>
Date:   Fri Mar 10 14:32:52 2023 -0800

    Roll Fuchsia Linux SDK to 12.20230309.0.1 (flutter#40231)

    Roll Fuchsia Linux SDK to 12.20230309.0.1

commit 3b07c4c
Author: Jonah Williams <jonahwilliams@google.com>
Date:   Fri Mar 10 14:24:45 2023 -0800

    [Impeller] remove unused shader, format malioc diff (flutter#40230)

    [Impeller] remove unused shader, format malioc diff
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2023
@engine-flutter-autoroll
739dc8b ae979a854 [Impeller] More sundry fixes to the Vulkan backend. (…
844288f 
…flutter/engine#40244) (flutter/flutter#122513)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2023
@engine-flutter-autoroll
2d1a5cd Revert "ae979a854 [Impeller] More sundry fixes to the Vulkan …
0ad4700 
…backend. (flutter/engine#40244) (#122513)" (flutter/flutter#122527)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2023
@engine-flutter-autoroll
739dc8b ae979a854 [Impeller] More sundry fixes to the Vulkan backend. (…
6875366 
…flutter/engine#40244) (flutter/flutter#122513)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2023
@engine-flutter-autoroll
2d1a5cd Revert "ae979a854 [Impeller] More sundry fixes to the Vulkan …
c562956 
…backend. (flutter/engine#40244) (#122513)" (flutter/flutter#122527)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
739dc8b ae979a854 [Impeller] More sundry fixes to the Vulkan backend. (…
2f1eb37 
…flutter/engine#40244) (flutter/flutter#122513)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
2d1a5cd Revert "ae979a854 [Impeller] More sundry fixes to the Vulkan …
e8c2666 
…backend. (flutter/engine#40244) (#122513)" (flutter/flutter#122527)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
739dc8b ae979a854 [Impeller] More sundry fixes to the Vulkan backend. (…
fcddfc2 
…flutter/engine#40244) (flutter/flutter#122513)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
2d1a5cd Revert "ae979a854 [Impeller] More sundry fixes to the Vulkan …
2aabc2e 
…backend. (flutter/engine#40244) (#122513)" (flutter/flutter#122527)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@bdero bdero Awaiting requested review from bdero

@dnfield dnfield Awaiting requested review from dnfield

Assignees

@chinmaygarde chinmaygarde

Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller platform-ios
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
2 participants
@chinmaygarde @jonahwilliams