Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip invalid renders in Dart #47323

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Skip invalid renders in Dart #47323

merged 4 commits into from
Oct 26, 2023

Conversation

dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Oct 25, 2023 •
edited
Loading

With this PR, invalid renders are skipped in Dart in both release build and debug build.

Part of flutter/flutter#137073 and part of relanding #45555.

Unit tests will be relanded in a following PR once this PR is confirmed performance-safe.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@dkwingsmt dkwingsmt requested a review from loic-sharma October 25, 2023 21:47
loic-sharma
loic-sharma approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 26, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 26, 2023

auto label is removed for flutter/engine/47323, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 26, 2023
@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 26, 2023
@auto-submit auto-submit bot merged commit bedc49e into flutter:main Oct 26, 2023
25 checks passed
@zanderso zanderso added revert Label used to revert changes in a closed and merged pull request. and removed revert Label used to revert changes in a closed and merged pull request. labels Oct 26, 2023
@dkwingsmt dkwingsmt deleted the check-render-rule-on-dart branch October 26, 2023 23:01
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 26, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 26, 2023
@engine-flutter-autoroll
bedc49efc Skip invalid renders in Dart (flutter/engine#47323)
339a4ed
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 27, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 87f384c2d70b to bedc49efc85c (1 revision) (#…
daec48d 
…137382)

flutter/engine@87f384c...bedc49e

2023-10-26 dkwingsmt@users.noreply.github.com Skip invalid renders in Dart (flutter/engine#47323)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@dkwingsmt dkwingsmt mentioned this pull request Nov 22, 2023
Merged
8 tasks
dkwingsmt added a commit to dkwingsmt/engine that referenced this pull request Jan 2, 2024
@dkwingsmt
Revert flutter#47323
d2df0d0
@dkwingsmt dkwingsmt mentioned this pull request Jan 2, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkwingsmt @loic-sharma @zanderso