Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Reland 2: Multiview Pipeline (#47239)" #49238

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Dec 19, 2023

This reverts #47239.

Internal performance test shows that this PR negatively affects startup time. I'll reland this PR in parts.

b/307872797

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@dkwingsmt dkwingsmt added revert Label used to revert changes in a closed and merged pull request. autosubmit Merge PR when tree becomes green via auto submit App and removed revert Label used to revert changes in a closed and merged pull request. labels Dec 19, 2023
@auto-submit auto-submit bot merged commit a379405 into flutter:main Dec 19, 2023
29 checks passed
@dkwingsmt dkwingsmt deleted the revert-2-mv-pipeling branch December 19, 2023 22:30
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 20, 2023
…140431)

flutter/engine@5279873...c70f0a4

2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 48f959a857da to d0f09ad481f7 (3 revisions) (flutter/engine#49264)
2023-12-19 dkwingsmt@users.noreply.github.com Revert "Reland 2: Multiview Pipeline  (#47239)" (flutter/engine#49238)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake pushed a commit to CoderDake/flutter that referenced this pull request Dec 28, 2023
…lutter#140431)

flutter/engine@5279873...c70f0a4

2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 48f959a857da to d0f09ad481f7 (3 revisions) (flutter/engine#49264)
2023-12-19 dkwingsmt@users.noreply.github.com Revert "Reland 2: Multiview Pipeline  (flutter#47239)" (flutter/engine#49238)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
dkwingsmt added a commit to dkwingsmt/engine that referenced this pull request Jan 18, 2024
dkwingsmt added a commit to dkwingsmt/engine that referenced this pull request Jan 22, 2024
dkwingsmt added a commit to dkwingsmt/engine that referenced this pull request Jan 24, 2024
dkwingsmt added a commit to dkwingsmt/engine that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants