-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Reland 2: Multiview Pipeline (#47239)" #49238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0ef5caa.
loic-sharma
approved these changes
Dec 19, 2023
dkwingsmt
added
revert
Label used to revert changes in a closed and merged pull request.
autosubmit
Merge PR when tree becomes green via auto submit App
and removed
revert
Label used to revert changes in a closed and merged pull request.
labels
Dec 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 20, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 20, 2023
…140431) flutter/engine@5279873...c70f0a4 2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 48f959a857da to d0f09ad481f7 (3 revisions) (flutter/engine#49264) 2023-12-19 dkwingsmt@users.noreply.github.com Revert "Reland 2: Multiview Pipeline (#47239)" (flutter/engine#49238) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this pull request
Dec 28, 2023
…lutter#140431) flutter/engine@5279873...c70f0a4 2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 48f959a857da to d0f09ad481f7 (3 revisions) (flutter/engine#49264) 2023-12-19 dkwingsmt@users.noreply.github.com Revert "Reland 2: Multiview Pipeline (flutter#47239)" (flutter/engine#49238) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
dkwingsmt
added a commit
to dkwingsmt/engine
that referenced
this pull request
Jan 18, 2024
… for now This reverts commit a379405.
dkwingsmt
added a commit
to dkwingsmt/engine
that referenced
this pull request
Jan 22, 2024
This reverts commit a379405.
dkwingsmt
added a commit
to dkwingsmt/engine
that referenced
this pull request
Jan 24, 2024
This reverts commit a379405.
dkwingsmt
added a commit
to dkwingsmt/engine
that referenced
this pull request
Feb 7, 2024
This reverts commit a379405.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #47239.
Internal performance test shows that this PR negatively affects startup time. I'll reland this PR in parts.
b/307872797
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.