Use top-level GN arg for Skottie instead of CanvasKit-specific arg. #50019
Conversation
The GN flag `skia_canvaskit_enable_skottie` is being retired at http://review.skia.org/805336
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jonahwilliams
added
the
autosubmit
…142205) flutter/engine@499ed00...d4d8f66 2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 571873c31056 to c0544410fc8e (1 revision) (flutter/engine#50030) 2024-01-25 71952488+johnstiles-google@users.noreply.github.com Use top-level GN arg for Skottie instead of CanvasKit-specific arg. (flutter/engine#50019) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The GN flag
skia_canvaskit_enable_skottieis being retired at http://review.skia.org/805336