-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace several calls to GrGLMakeNativeInterface with more direct APIs #53064
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test-exempt: rolling dependency / refactor with no semantic change |
…149320) flutter/engine@fb64b9a...2fedfd3 2024-05-30 skia-flutter-autoroll@skia.org Roll Skia from e256482ed29c to 8da05c8d40af (1 revision) (flutter/engine#53112) 2024-05-30 kjlubick@users.noreply.github.com Replace several calls to GrGLMakeNativeInterface with more direct APIs (flutter/engine#53064) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#149320) flutter/engine@fb64b9a...2fedfd3 2024-05-30 skia-flutter-autoroll@skia.org Roll Skia from e256482ed29c to 8da05c8d40af (1 revision) (flutter/engine#53112) 2024-05-30 kjlubick@users.noreply.github.com Replace several calls to GrGLMakeNativeInterface with more direct APIs (flutter/engine#53064) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
We are restructuring Skia and plan to remove GrGLMakeNativeInterface at some point. This updates as many places as possible to use the direct and explicit instantiation instead of having "Skia guess". This should ideally not be changing behavior - if it does, then the PR should be modified.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.