[Impeller] enable Impeller by default on Android. #53099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
changed the title
chinmaygarde
approved these changes
May 29, 2024
zanderso
approved these changes
May 29, 2024
jonahwilliams
changed the title
jonahwilliams
changed the title
jonahwilliams
added
the
test: all
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Okay, turns out --no-enable-impeller never actually worked on android. That is fixed now. |
bdero
approved these changes
May 30, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 30, 2024
…149291) flutter/engine@4adf453...19707e8 2024-05-30 jonahwilliams@google.com [Impeller] enable Impeller by default on Android. (flutter/engine#53099) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
May 30, 2024
After #53099, impeller is always enabled, even if the manifest disables it using `io.flutter.embedding.android.EnableImpeller`. This PR causes it to respect the manifest value if it is explicitly disabled. Fixes b/343603270 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
8 tasks
auto-submit bot
added a commit
that referenced
this pull request
May 30, 2024
…53108)" (#53124) Reverts: #53108 Initiated by: jonahwilliams Reason for reverting: Probably --no-enable-impeller isn't working Original PR Author: jiahaog Reviewed By: {jonahwilliams} This change reverts the following previous change: After #53099, impeller is always enabled, even if the manifest disables it using `io.flutter.embedding.android.EnableImpeller`. This PR causes it to respect the manifest value if it is explicitly disabled. Fixes b/343603270 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
|
reason for revert: manifest opt out doens't work. |
jonahwilliams
added
the
revert
auto-submit bot
pushed a commit
that referenced
this pull request
May 30, 2024
This reverts commit 19707e8.
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
May 30, 2024
…53125) Reverts: #53099 Initiated by: jonahwilliams Reason for reverting: manifest opt out doens't work. Original PR Author: jonahwilliams Reviewed By: {bdero, zanderso, chinmaygarde} This change reverts the following previous change: All plugin migrations have landed. Enable impeller by default on Android.
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
…lutter#149291) flutter/engine@4adf453...19707e8 2024-05-30 jonahwilliams@google.com [Impeller] enable Impeller by default on Android. (flutter/engine#53099) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All plugin migrations have landed. Enable impeller by default on Android.