Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Support woff2 fonts #55908

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[web] Support woff2 fonts #55908

wants to merge 11 commits into from

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Oct 16, 2024

  • Enable support for WOFF2 fonts.
  • Add Brotli depndency (increases CK size by ~53KB compressed, including the Brotli dictionary).
  • Use split WOFF2 fonts for Emoji.
  • Remove the useColorEmoji runtime config flag.

Partially based off of #41282
Fixes flutter/flutter#119536
Contributes to flutter/flutter#153974 and opens the door for moving more fonts to WOFF2.

Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #55908 at sha b4524a3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-web Code specifically for the web engine will affect goldens
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web][3.7] Emojis are not properly rendered
2 participants