-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS: Fix flaky tests (remove timeouts) #55961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
auto label is removed for flutter/engine/55961, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
When run repeatedly, some of the iOS unit tests can relatively easily blow their test timeouts. Since we're testing behaviour and not performance in these tests there's no need to enforce a particular timeout. The bots will fail if the tests timeout, regardless.
ca4e813
to
2bf79ee
Compare
auto label is removed for flutter/engine/55961, due to - The status or check suite Linux local_engine_builds has failed. Please fix the issues identified (or deflake) before re-applying this label. |
…157215) flutter/engine@76d310e...dd37446 2024-10-19 robert.ancell@canonical.com Move keymap from FlKeyboardViewDelegate to FlKeyboardManager (flutter/engine#55942) 2024-10-19 jonahwilliams@google.com [UI] fix scene builder parameter naming. (flutter/engine#55969) 2024-10-19 chris@bracken.jp iOS: Improve thread safety of first frame callback (flutter/engine#55966) 2024-10-18 chris@bracken.jp iOS: Fix flaky tests (remove timeouts) (flutter/engine#55961) 2024-10-18 jonahwilliams@google.com [Impeller] allocate the impeller onscreen texture from the render target cache. (flutter/engine#55943) 2024-10-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 9F_NaKPd2twhbPwP7... to tNQZ8d5mRYpe3--lk... (flutter/engine#55963) 2024-10-18 30870216+gaaclarke@users.noreply.github.com Started filtering out close line segments in rrect polylines. (flutter/engine#55929) 2024-10-18 chinmaygarde@google.com [Impeller] libImpeller: Allow custom font registrations. (flutter/engine#55934) 2024-10-18 chris@bracken.jp Re-reland "iOS: Migrate FlutterEngine to ARC" (flutter/engine#55962) 2024-10-18 chinmaygarde@google.com [Impeller] libImpeller: Add a README. (flutter/engine#55940) 2024-10-18 chris@bracken.jp iOS: Eliminate needless profiler metrics ivar (flutter/engine#55957) 2024-10-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] one descriptor pool per frame. (#55939)" (flutter/engine#55959) 2024-10-18 chris@bracken.jp Revert "Reland "iOS: Migrate FlutterEngine to ARC" (#55937)" (flutter/engine#55954) 2024-10-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 993d3069f42e to a51df90298ca (7 revisions) (flutter/engine#55951) 2024-10-18 jonahwilliams@google.com [engine] add back opt out for merged threads. (flutter/engine#55952) 2024-10-18 jonahwilliams@google.com [Impeller] one descriptor pool per frame. (flutter/engine#55939) 2024-10-18 jonahwilliams@google.com [Impeller] add mechanism for sharing bdf inputs. (flutter/engine#55701) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 9F_NaKPd2twh to tNQZ8d5mRYpe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
When run repeatedly, some of the iOS unit tests can relatively easily blow their test timeouts. Since we're testing behaviour and not performance in these tests there's no need to enforce a particular timeout.
The bots will fail if the tests timeout, regardless.
Issue: flutter/flutter#157231
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.