Properly report dart format errors
#57206
Merged
+62
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci/bin/format.dart
Outdated
| incorrect = completedJobs.where((WorkerJob job) => job.result.exitCode == 1); | ||
| final List<WorkerJob> incorrectJobs = incorrect = []; | ||
| for (final WorkerJob job in completedJobs) { | ||
| if ((job.result.exitCode == 1 && job.result.stderr.isNotEmpty) || job.result.exitCode > 1) { |
There was a problem hiding this comment.
Can't the exit code also be negative?
Seems like you want job.result.exitCode != 0 && (job.result.stderr.isNotEmpty || job.result.exitCode != 1)
gspencergoog
added
the
autosubmit
goderbauer
added
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/57206, due to - The status or check suite Linux local_engine_builds has failed. Please fix the issues identified (or deflake) before re-applying this label. |
goderbauer
added
autosubmit
goderbauer
added
the
autosubmit
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 16, 2024
This applied the improvements from flutter/engine#57206 to the flutter/flutter version of that script (hopefully, we can deduplicate this soon with the repo merge).
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 17, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 17, 2024
…160396) flutter/engine@4944aeb...1d2eb3f 2024-12-16 goderbauer@google.com Properly report `dart format` errors (flutter/engine#57206) 2024-12-16 skia-flutter-autoroll@skia.org Roll Skia from 7fc6934b2034 to 2c5159518cf2 (1 revision) (flutter/engine#57229) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
`dart format` can fail (e.g. if a file contains invalid dart code). Previously, those failures were swallowed. This change adds logic to properly print those failures to the terminal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dart formatcan fail (e.g. if a file contains invalid dart code). Previously, those failures were swallowed. This change adds logic to properly print those failures to the terminal.