-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to help generate PR messages #8074
Conversation
tools/engine_roll_pr_desc.sh
Outdated
echo 'Usage: engine_roll_pr_desc.sh <from git hash>..<to git hash>' | ||
exit 1 | ||
fi | ||
git log --oneline --no-merges --no-color $1 | sed 's/^/flutter\/engine@/g' | sed -e 's/(\(#[0-9]*)\)/\(flutter\/engine\1/g' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an EOF newline. (Rationale)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Oh nice -- I have a vim macro for this that I can deprecate :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm modulo EOF newline.
flutter/engine@a48cd16...6031407 git log a48cd16..6031407 --no-merges --oneline 6031407 Roll src/third_party/skia 88b8d1124b72..3d1b941f3a7d (27 commits) (flutter/engine#8082) 95ef58c Add script to help generate PR messages (flutter/engine#8074) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (mklim@google.com), and stop the roller if necessary.
This will massage the output of
git log
for a commit message to flutter/flutter. Simply meant to help with manual rolls - normally the autoroller takes care of this.