Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to help generate PR messages #8074

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Mar 7, 2019

This will massage the output of git log for a commit message to flutter/flutter. Simply meant to help with manual rolls - normally the autoroller takes care of this.

@dnfield dnfield requested review from GaryQian and liyuqian March 7, 2019 21:46
echo 'Usage: engine_roll_pr_desc.sh <from git hash>..<to git hash>'
exit 1
fi
git log --oneline --no-merges --no-color $1 | sed 's/^/flutter\/engine@/g' | sed -e 's/(\(#[0-9]*)\)/\(flutter\/engine\1/g'
Copy link
Member

@cbracken cbracken Mar 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an EOF newline. (Rationale)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@cbracken
Copy link
Member

cbracken commented Mar 7, 2019

Oh nice -- I have a vim macro for this that I can deprecate :)

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo EOF newline.

@dnfield dnfield added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 7, 2019
@dnfield dnfield merged commit 95ef58c into flutter:master Mar 8, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 8, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 8, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Mar 8, 2019
flutter/engine@a48cd16...6031407

git log a48cd16..6031407 --no-merges --oneline
6031407 Roll src/third_party/skia 88b8d1124b72..3d1b941f3a7d (27 commits) (flutter/engine#8082)
95ef58c Add script to help generate PR messages (flutter/engine#8074)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (mklim@google.com), and stop
the roller if necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants