Fixed service isolate not being initialized correctly due to bad name #8251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name for the service isolate was being set to the empty string, causing the microtask loop to not be run on the service isolate leading to the service hanging on the first 'await'. See https://dart-review.googlesource.com/c/sdk/+/97107 for revert due to this issue.
|
We can remote the second argument to DartCreateAndStartServiceIsolate and make its implementation say "main" or something. |
Sure, that makes more sense. |
chinmaygarde
approved these changes
Mar 26, 2019
a-siva
approved these changes
Mar 26, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 26, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 26, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 27, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 27, 2019
This was referenced Mar 27, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 27, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 27, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 27, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 27, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 27, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 27, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 27, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 27, 2019
This was referenced Mar 27, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 27, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Mar 27, 2019
flutter/engine@0d83a2e...3a3f707 git log 0d83a2e..3a3f707 --no-merges --oneline 3a3f707 Reland "Allow specification of std::functions as native entrypoints from Dart code." (flutter/engine#8329) d4275d9 Roll src/third_party/skia 576eb87a2d2d..99ccc0ca87e6 (5 commits) (flutter/engine#8328) 3a415c4 Map glfw into third_party, and roll buildroot (flutter/engine#8308) ce9ea58 [fuchsia] Disable FML_TRACE_COUNTER events to unblock roll (flutter/engine#8325) 4849658 Roll src/third_party/dart 8a92d2a8d9..991c9da720 (2 commits) 20c241a Roll src/third_party/skia c476e5da4fef..576eb87a2d2d (7 commits) (flutter/engine#8324) cadcf1c Roll src/third_party/dart f3fd1943fc..8a92d2a8d9 (16 commits) 66141eb Roll src/third_party/skia d1c271bd39f0..c476e5da4fef (2 commits) (flutter/engine#8322) e5b31cd Roll src/third_party/skia cec20280b3fb..d1c271bd39f0 (3 commits) (flutter/engine#8321) 1daff5c Roll src/third_party/skia bf341ae88c83..cec20280b3fb (3 commits) (flutter/engine#8320) 87db585 Roll src/third_party/skia 45d5f702133e..bf341ae88c83 (2 commits) (flutter/engine#8316) fd7d7fa Add a11y support for embedded iOS platform view (flutter/engine#8156) f64ee01 Roll src/third_party/skia d2ca31218bc4..45d5f702133e (11 commits) (flutter/engine#8315) f521df3 Fixed service isolate not being initialized correctly due to bad name (flutter/engine#8251) 80b825c Roll src/third_party/dart 093c2909fe..f3fd1943fc (13 commits) (flutter/engine#8310) 7e77d5c Revert "Allow specification of std::functions as native entrypoints from Dart code. (#8309)" (flutter/engine#8312) 400a86a Allow specification of std::functions as native entrypoints from Dart code. (flutter/engine#8309) 51f23fe [vulkan] Add FUCHSIA external sem/mem extensions 78de8dc Enable lambda like native callbacks in tests and add support for custom entrypoints. (flutter/engine#8299) 2812c7d Roll src/third_party/skia 62fd6c411622..d2ca31218bc4 (9 commits) (flutter/engine#8307) 95f9134 Roll src/third_party/skia d90004516a63..62fd6c411622 (4 commits) (flutter/engine#8306) 358273b Roll src/third_party/skia 33211b2c7a02..d90004516a63 (1 commits) (flutter/engine#8305) 2804057 Roll src/third_party/skia 80dd599e91d0..33211b2c7a02 (1 commits) (flutter/engine#8303) a673bbf Roll src/third_party/skia c5ee499f2c59..80dd599e91d0 (5 commits) (flutter/engine#8301) d88037d Roll src/third_party/dart fa74184b7a..093c2909fe (71 commits) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop the roller if necessary.
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…flutter#8251) * Fixed service isolate not being initialized correctly due to bad name The name for the service isolate was being set to the empty string, causing the microtask loop to not be run on the service isolate leading to the service hanging on the first 'await'. See https://dart-review.googlesource.com/c/sdk/+/97107 for revert due to this issue. * Removed unnecessary params from DartCreateAndStartServiceIsolate
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…bad name (flutter#8251)" This reverts commit 787abec.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…bad name (flutter#8251)" This reverts commit 787abec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name for the service isolate was being set to the empty string, causing the microtask loop to not be run on the service isolate leading to the service hanging on the first 'await'. See https://dart-review.googlesource.com/c/sdk/+/97107 for revert due to this issue.
Fixes dart-lang/sdk#36232.