Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows build. #8336

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Fix Windows build. #8336

merged 1 commit into from
Mar 27, 2019

Conversation

chinmaygarde
Copy link
Member

No description provided.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm_hanko

@chinmaygarde
Copy link
Member Author

Landing on red as this fixes the bots.

@chinmaygarde chinmaygarde merged commit 6800245 into flutter:master Mar 27, 2019
@chinmaygarde chinmaygarde deleted the fix_win3 branch March 27, 2019 23:43
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 28, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Mar 28, 2019
flutter/engine@37947f9...c4d14a0

git log 37947f9..c4d14a0 --no-merges --oneline
c4d14a0 Roll src/third_party/skia e4c67058ddb1..01a065884b7d (1 commits) (flutter/engine#8344)
5983b7a Roll src/third_party/dart ffee99d79b..cf32584870 (6 commits)
84c62b4 Build Windows shell (flutter/engine#8331)
6415277 Roll src/third_party/skia 8d2c19554e4a..e4c67058ddb1 (1 commits) (flutter/engine#8341)
a011010 Roll src/third_party/dart 991c9da720..ffee99d79b (7 commits)
2098398 Cleanups to run_tests.sh script (flutter/engine#8337)
5c99138 Build GLFW from source for Linux shell (flutter/engine#8327)
6800245 Fix Windows build. (flutter/engine#8336)
6d8b836 Remove use of epoxy from Linux shell (flutter/engine#8334)
4efc321 Add super call in FLEView reshape (flutter/engine#8335)
cb8eb80 Allow embedders to specify their own task runner interfaces. (flutter/engine#8273)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
RBogie pushed a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
RBogie added a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
RBogie added a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants