[DropdownButton]: Fix alignment parameter doesn't work for hint when isExpanded: true
#102752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
HansMuller
requested review from
QuncCccccc
and removed request for
gspencergoog
QuncCccccc
reviewed
May 2, 2022
| hint: const Text(hintText)), | ||
| ); | ||
| expect(tester.getTopLeft(find.text(hintText)).dx, 712.0); | ||
| }); |
There was a problem hiding this comment.
LGTM. Just double check, do we need tests to cover AlightmentDirectional.topStart, AlightmentDirectional.topEnd, AlightmentDirectional.bottomStart, AlightmentDirectional.buttomEnd and etc.?
There was a problem hiding this comment.
Hey, thanks for looking into this. It makes sense it is certainly possible to align at corners when setting itemHeight
I've updated the test and added comments to make it easier to follow the large test.
TahaTesser
force-pushed
the
fix_dropdown_hint_alignment
branch
from
3bd17cb to
d262f16
Compare
…en `isExpanded: true`
TahaTesser
force-pushed
the
fix_dropdown_hint_alignment
branch
from
d262f16 to
7ac2342
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2022
…hint` when `isExpanded: true` (flutter/flutter#102752)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 6, 2022
…hint` when `isExpanded: true` (flutter/flutter#102752)
TahaTesser
changed the title
alignmentparameter doesn't work for hint when isExpanded: truealignment parameter doesn't work for hint when isExpanded: true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #102751
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.