Update IntegrationTestPlugin.m

[barringb]

The integration_test native plugin is not being correctly registered on iOS when running tests via flutter drive. Adding an
IntegrationTestPlugin instance to registerWithRegistrar method in IntegrationTestPlugin.m.

This plugin instance was previously removed before integration_test was migrated from e2e to prevent an error where the e2e plugin would not exit testing. This does not appear to be an issue with integration_test and my tests exit properly regardless of run with flutter drive or through XCode.

List which issues are fixed by this PR. You must list at least one issue.
#91668

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
• I signed the CLA.
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

[pdblasi-google]

LGTM

@barringb Thanks for the PR and the great write-up! The links and history provided some much needed context, so I really appreciate it!

[jmagman]

This does not appear to be an issue with integration_test and my tests exit properly regardless of run with flutter drive or through XCode.

You tested this with static libraries (the default with an Objective-C project)?

integration_test was migrated from e2e to prevent an error where the e2e plugin would not exit testing.

I'm not sure how that would have fixed this issue. I need to check out this change and see if I can reproduce #48601

[jmagman]

I tried to get the hang to reproduce and couldn't, details in #91668 (comment)

Instead of this one line change, let's actually remove the entire workaround from flutter/plugins#2465. Meaning remove the exposed -setupChannels: method, and change the +registerWithRegistrar to its original

+ (void)registerWithRegistrar:(NSObject<FlutterPluginRegistrar> *)registrar {
  FlutterMethodChannel *channel = [FlutterMethodChannel methodChannelWithName:kIntegrationTestPluginChannel
                                                              binaryMessenger:registrar.messenger];
  [registrar addMethodCallDelegate:[self instance] channel:channel];
}

Let me know if you would prefer I close this and open my own PR instead.

[jmagman]

Requesting -setupChannels: removal.

[goderbauer]

(Triage) @barringb Do you still have plans to follow-up on the feedback given above? Thanks!

[jmagman]

I wound up reverting flutter/plugins#2465 in #123729, including removing the now-dead code.

@barringb Thank you for your contribution and kicking off this investigation!