-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up scrollable.dart for 2D #122357
Clean up scrollable.dart for 2D #122357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a mild preference for scrollable_helpers to have its own test file but I can see the value in showing that the existing tests still pass after the move.
I concur! I will move the related tests into a new file in a separate PR to ensure ensure everything still checks out. 👍 |
Clean up scrollable.dart for 2D
Part of the 2D scrolling proposal: flutter.dev/go/2D-Foundation
Part of #122355 (tests will be migrated separately for validation)
This relocates some public APIs to another file in order to make some breathing room for TwoDimensionalScrollable.
I also tidied up some getters that were scattered throughout ScrollableState.
This required exposing 2 new getters on ScrollableState
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.