Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error about missing MediaQuery #124243

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

goderbauer
Copy link
Member

We forgot to update the error message when we moved the MediaQuery.

@goderbauer goderbauer requested a review from HansMuller April 5, 2023 18:03
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 5, 2023
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@goderbauer goderbauer force-pushed the fixMediaQueryError branch from ddba112 to c68593e Compare April 5, 2023 19:23
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 5, 2023

auto label is removed for flutter/flutter, pr: 124243, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@goderbauer goderbauer force-pushed the fixMediaQueryError branch from c68593e to 28b4c1c Compare April 6, 2023 04:11
@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@goderbauer goderbauer merged commit 98f35be into flutter:master Apr 6, 2023
@goderbauer goderbauer deleted the fixMediaQueryError branch April 6, 2023 05:19
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 6, 2023
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants