Roll Packages from bb5a25815cae to 72356fda4684 (8 revisions)

[engine-flutter-autoroll]

flutter/packages@bb5a258...72356fd

2024-11-08 stuartmorgan@google.com [various] Update example app minSdkVersions (flutter/packages#8035)
2024-11-07 32538273+ValentinVignal@users.noreply.github.com [go_router] Activate leak testing (flutter/packages#7546)
2024-11-07 louisehsu@google.com [in_app_purchase_storekit] Add restore purchases and receipts (flutter/packages#7964)
2024-11-07 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds remaining methods for internal wrapper of the Android native BaseManager (flutter/packages#7943)
2024-11-07 58529443+srujzs@users.noreply.github.com [google_sign_in/google_identity_services] Clear-up documentation of callbacks in various APIs and uses of those APIs (flutter/packages#8029)
2024-11-07 alex@mariuti.com [flutter_svg] wasm compatibility (flutter/packages#8014)
2024-11-06 jessiewong401@gmail.com Applied Gradle Plugins Declaratively for Multiple Plugin Example Apps (Part 2) (flutter/packages#8019)
2024-11-06 engine-flutter-autoroll@skia.org Roll Flutter from 29d40f7 to 73546b3 (20 revisions) (flutter/packages#8028)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

[auto-submit]

auto label is removed for flutter/flutter/158378, due to - The status or check suite Windows tool_integration_tests_2_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.

[auto-submit]

auto label is removed for flutter/flutter/158378, due to - The status or check suite Windows tool_integration_tests_2_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.

[engine-flutter-autoroll]

AutoRoller is stopped; closing the active roll.

[camsim99]

Seeing this failure from plugin_dependencies_test.dart in the framework:

[2024-11-08 09:24:18.258412] [STDOUT] ═════════════════╡ ••• Build plugin A example Android app ••• ╞═════════════════
[2024-11-08 09:24:18.258439] [STDOUT] 
[2024-11-08 09:24:18.258699] [STDOUT] Executing "/Volumes/Work/s/w/ir/x/w/rc/tmpjbdca2y9/flutter sdk/bin/flutter build apk --target-platform android-arm --ci --debug-logs-dir=/Volumes/Work/s/w/ir/x/w/rc/flutter_logs_dir" in "/Volumes/Work/s/w/ir/x/t/flutter_plugin_dependencies.kGQbcR/plugin_a/example" with environment {BOT: true, LANG: en_US.UTF-8}
[2024-11-08 09:24:19.763637] [STDOUT] stdout: Downloading android-arm-profile/darwin-x64 tools...              1,241ms
[2024-11-08 09:24:20.189095] [STDOUT] stdout: Downloading android-arm-release/darwin-x64 tools...                227ms
[2024-11-08 09:24:20.612530] [STDOUT] stdout: Downloading android-arm64-profile/darwin-x64 tools...              247ms
[2024-11-08 09:24:21.018244] [STDOUT] stdout: Downloading android-arm64-release/darwin-x64 tools...              213ms
[2024-11-08 09:24:21.418505] [STDOUT] stdout: Downloading android-x64-profile/darwin-x64 tools...                223ms
[2024-11-08 09:24:21.829678] [STDOUT] stdout: Downloading android-x64-release/darwin-x64 tools...                218ms
[2024-11-08 09:24:22.617304] [STDOUT] stdout: 
[2024-11-08 09:24:45.525262] [STDOUT] stdout: Running Gradle task 'assembleRelease'...                        
[2024-11-08 09:24:45.526159] [STDOUT] stderr: Your project is configured with Android NDK 26.1.10909125, but the following plugin(s) depend on a different Android NDK version:
[2024-11-08 09:24:45.526355] [STDOUT] stderr: - integration_test requires Android NDK 27.0.12077973
[2024-11-08 09:24:45.526458] [STDOUT] stderr: - plugin_a requires Android NDK 27.0.12077973
[2024-11-08 09:24:45.526511] [STDOUT] stderr: - plugin_b requires Android NDK 27.0.12077973
[2024-11-08 09:24:45.526623] [STDOUT] stderr: - plugin_d requires Android NDK 27.0.12077973
[2024-11-08 09:24:45.526666] [STDOUT] stderr: Fix this issue by using the highest Android NDK version (they are backward compatible).
[2024-11-08 09:24:45.527108] [STDOUT] stderr: Add the following to /Volumes/Work/s/w/ir/x/t/flutter_plugin_dependencies.kGQbcR/plugin_a/example/android/app/build.gradle.kts:
[2024-11-08 09:24:45.527165] [STDOUT] stderr: 
[2024-11-08 09:24:45.527268] [STDOUT] stderr:     android {
[2024-11-08 09:24:45.527469] [STDOUT] stderr:         ndkVersion = "27.0.12077973"
[2024-11-08 09:24:45.527556] [STDOUT] stderr:         ...
[2024-11-08 09:24:45.527750] [STDOUT] stderr:     }
[2024-11-08 09:24:45.527813] [STDOUT] stderr: 
[2024-11-08 09:24:57.777666] [STDOUT] stdout: Font asset "MaterialIcons-Regular.otf" was tree-shaken, reducing it from 1645184 to 1324 bytes (99.9% reduction). Tree-shaking can be disabled by providing the --no-tree-shake-icons flag when building your app.
[2024-11-08 09:25:39.482461] [STDOUT] stdout: Running Gradle task 'assembleRelease'...                           76.8s
[2024-11-08 09:25:39.601726] [STDOUT] stdout: ✓ Built build/app/outputs/flutter-apk/app-release.apk (6.2MB)
[2024-11-08 09:25:39.617757] [STDOUT] 
[2024-11-08 09:25:39.617821] [STDOUT]

@matanlurey digging into this but do you have any insights here? not sure why packages would impact this test...looks like it is just building an app

[matanlurey]

Unfortunately it's just really hard reading our error logs, but here is the issue:

            * What went wrong:
            Execution failed for task ':app:compressDebugAssets'.
            > A failure occurred while executing com.android.build.gradle.internal.tasks.CompressAssetsWorkAction
               > Java heap space

I previously filed #157640, perhaps @bkonyi we should raise priority on this?

/cc @christopherfujino as well from an infra-POV.

[bkonyi]

Unfortunately it's just really hard reading our error logs, but here is the issue:

            * What went wrong:
            Execution failed for task ':app:compressDebugAssets'.
            > A failure occurred while executing com.android.build.gradle.internal.tasks.CompressAssetsWorkAction
               > Java heap space

I previously filed #157640, perhaps @bkonyi we should raise priority on this?

/cc @christopherfujino as well from an infra-POV.

I had tried landing #158330 yesterday to resolve this, but apparently it didn't help...

[christopherfujino]

Unfortunately it's just really hard reading our error logs, but here is the issue:

            * What went wrong:
            Execution failed for task ':app:compressDebugAssets'.
            > A failure occurred while executing com.android.build.gradle.internal.tasks.CompressAssetsWorkAction
               > Java heap space

I previously filed #157640, perhaps @bkonyi we should raise priority on this?
/cc @christopherfujino as well from an infra-POV.

I had tried landing #158330 yesterday to resolve this, but apparently it didn't help...

I don't think that change would have affected this test, as you edited packages/flutter_tools/test/integration.shard/test_data/deferred_components_project.dart, which I don't think this test depends on.

[christopherfujino]

Unfortunately it's just really hard reading our error logs, but here is the issue:

            * What went wrong:
            Execution failed for task ':app:compressDebugAssets'.
            > A failure occurred while executing com.android.build.gradle.internal.tasks.CompressAssetsWorkAction
               > Java heap space

I previously filed #157640, perhaps @bkonyi we should raise priority on this?
/cc @christopherfujino as well from an infra-POV.

I had tried landing #158330 yesterday to resolve this, but apparently it didn't help...

I don't think that change would have affected this test, as you edited packages/flutter_tools/test/integration.shard/test_data/deferred_components_project.dart, which I don't think this test depends on.

cc @reidbaker regarding not globally bumping the heap limit (my concern about not globally bumping it would be that we would be doing whack-a-mole).

[matanlurey]

I can understand not globally bumping if we had the tools to more easily debug this, i.e. this failure was flagged as such and there was a simple process to bump it (like in google3). Since we don't have that environment it seems very costly to just wait until the next Java process OOMs.

[reidbaker]

I think the cause of this error is not going to be fixed with more memory but we are welcome to try to bump everything and see if it helps.

[camsim99]

Going to merge this. Assuming further steps can be discussed in #157640 but let me know if that's not the case!