Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Ensure sliders have useful a11y labels #226

Closed
guidezpl opened this issue Jul 21, 2020 · 8 comments · Fixed by flutter/flutter#68019
Closed

Ensure sliders have useful a11y labels #226

guidezpl opened this issue Jul 21, 2020 · 8 comments · Fixed by flutter/flutter#68019
Labels
a11y Related to accessibility demo Building/fixing/updating a demo enhancement New feature or request P1 Priority 1 - Must have

Comments

@guidezpl
Copy link
Member

It would be nice if these sliders had accessibility labels, just as an example for developers to follow. Currently, screen readers only read the value

@guidezpl guidezpl added enhancement New feature or request P2 Priority 2 - Should have a11y Related to accessibility demo Building/fixing/updating a demo labels Jul 21, 2020
clocksmith pushed a commit to clocksmith/gallery that referenced this issue Jul 23, 2020
@guidezpl
Copy link
Member Author

Blocked on framework changes. flutter/flutter#63524 would allow us to fix this

@guidezpl guidezpl added P1 Priority 1 - Must have and removed P2 Priority 2 - Should have labels Aug 24, 2020
@clocksmith
Copy link
Contributor

Right now the screen reader announces the value. After this change, would it first announce that the focused element is a slider, then announce the value?

@guidezpl
Copy link
Member Author

I believe so.

@apomalyn
Copy link

apomalyn commented Oct 2, 2020

@guidezpl I'm very new to open source and I don't see any CONTRIBUTING.md inside the repo so I will just ask. Can I take this issue?
If yes, what is the correct process to contribute?

Thanks :D

@guidezpl
Copy link
Member Author

guidezpl commented Oct 6, 2020

Hi @apomalyn. Sure! I've created an upstream bug that (I believe) you can assign yourself to flutter/flutter#67396. The CONTRIBUTING.md for flutter/flutter applies

@apomalyn
Copy link

apomalyn commented Oct 6, 2020

Hi @guidezpl ! Thanks, 😄 I can't assign the issue to myself but it's not a problem, I will drop a comment there to signify my interest on the issue.

To be sure to correctly understand the issue, the a11y message about the slider currently read only the value of the slider and we would like to have a nice message like "Slider value is XX"?
This problem is from the Flutter framework, not gallery, this is why you opened an issue there. Right?

Sorry if my questions are silly I'm not really good in English and I don't want to want you loose time by reviewing useless PR 😅

@guidezpl
Copy link
Member Author

guidezpl commented Oct 7, 2020

Yes this is a framework PR, but it's not about changing the label manually. Rather, setting Semantics.slider (docs) to true for those three widgets

@apomalyn
Copy link

apomalyn commented Oct 8, 2020

Thank you a lot!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y Related to accessibility demo Building/fixing/updating a demo enhancement New feature or request P1 Priority 1 - Must have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants