-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Remove the AnimatedSize vsync parameter #480
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but have a couple questions
@@ -556,7 +556,6 @@ class _ExpandingBottomSheetState extends State<ExpandingBottomSheet> | |||
key: _expandingBottomSheetKey, | |||
duration: const Duration(milliseconds: 225), | |||
curve: Curves.easeInOut, | |||
vsync: this, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this class still need to be a TickerProviderStateMixin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the TickerProviderStateMixin
@@ -405,7 +405,6 @@ class _GalleryDemoPageState extends State<GalleryDemoPage> | |||
); | |||
} else { | |||
section = AnimatedSize( | |||
vsync: this, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this class still need to be a TickerProviderStateMixin
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still needed because _GalleryDemoPageState
is also creating an AnimationController
that uses a TickerProvider
This is needed in order to land flutter/flutter#80554, which will deprecate AnimatedSize.vsync
0b5bcb1
to
9817044
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is needed in order to land flutter/flutter#80554,
which will deprecate AnimatedSize.vsync