rename local functions with _s

[pq]

These will be flagged by the next linter release which updates non_constant_identifier_names to flag local functions.

See also:

• rename local functions with _s flutter#102615
• https://dart-review.googlesource.com/c/sdk/+/242391
• no_leading_underscores_for_local_identifiers doesn't complain about local functions dart-lang/linter#3360

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read the Flutter Style Guide recently, and have followed its advice.
• I signed the CLA.
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[goderbauer]

LGTM

Thanks for cleaning this up!

[pq]

@goderbauer: is the goldens failure legitimate? Any advice?

[guidezpl]

The goldens at the bottom of https://github.com/flutter/gallery/actions/runs/2233733806 looks to be showing slight changes in shadow rendering

[goderbauer]

I think those goldens just need to be updated as documented here: https://github.com/flutter/gallery/tree/master/test_goldens#updating-goldens

[pq]

Good deal. Updated 🤞

[goderbauer]

Looks like the golden check is still unhappy even though there is no visible difference...

@guidezpl could you help out here?

[pq]

@guidezpl, @goderbauer: I regenerated (on Mac OS) and am still seeing failures...

I'm also a little puzzled as to why my PR would provoke a need to regenerate?

[guidezpl]

The icons render differently on the home_page_desktop_dark and home_page_desktop_light images.

I'm hesitant to merge this even with new screenshots, because we've often found they're the cause of upstream work landing and being reverted. Meaning, we end up having to revert screenshots too. Alternatively, we could make the Goldens check not required, or at least allow team members to merge without all status checks.

@godofredoc might be able to help with that since even team members don't have access to the repo's settings

[pq]

@guidezpl, @godofredoc : any thoughts here? I'm happy to back out my goldens changes.

[godofredoc]

@guidezpl, @godofredoc : any thoughts here? I'm happy to back out my goldens changes.

Removed golden tests from the required list.