This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Cupertino demo improvements #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! |
|
Yeah the goldens have been failing for a while. I was waiting for things to settle upstream (low-level rendering changes). I'll get new goldens in. |
pennzht
approved these changes
May 3, 2022
| test('verify code segments are up to date', () async { | ||
| final currentCodeSegments = readCodeSegments(); | ||
| var newCodeSegments = await getCodeSegments(); | ||
|
|
||
| expect(standardizeLineEndings(newCodeSegments), | ||
| standardizeLineEndings(currentCodeSegments), | ||
| expect(_compareCodeSegments(currentCodeSegments, newCodeSegments), true, |
There was a problem hiding this comment.
I like how this change simplifies the log!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easy fixes to cupertino demos:
CupertinoSliverRefreshControlis more complete, remove this demoRemaining issues are in the framework (e.g. flutter/flutter#54241)
Additonal change: I made the test which verifies
code_segments.dartis up to date less verbose in CI, and make it just show the error instead. The full diff took forever to render and hid the actual error.