[image_picker] Remove input element after completion (#5654)

This PR attempts to remove the input element added to the DOM after image selection is completed. Fixes flutter/flutter#139442
flutter · Jan 5, 2024 · 15115f3 · 15115f3
1 parent e8fb05f
commit 15115f3
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 3 deletions.
diff --git a/AUTHORS b/AUTHORS
@@ -74,3 +74,4 @@ Twin Sun, LLC <google-contrib@twinsunsolutions.com>
 Amir Panahandeh <amirpanahandeh@gmail.com>
 Daniele Cambi <dancam.dev@gmail.com>
 Michele Benedetti <michelebenx98@gmail.com>
+Taskulu LDA <contributions@taskulu.com>
diff --git a/packages/image_picker/image_picker_for_web/CHANGELOG.md b/packages/image_picker/image_picker_for_web/CHANGELOG.md
@@ -1,6 +1,7 @@
-## NEXT
+## 3.0.2
 
 * Updates minimum supported SDK version to Flutter 3.10/Dart 3.0.
+* Removes input element after completion
 
 ## 3.0.1
 

diff --git a/...image_picker/image_picker_for_web/example/integration_test/image_picker_for_web_test.dart b/...image_picker/image_picker_for_web/example/integration_test/image_picker_for_web_test.dart
@@ -50,6 +50,9 @@ void main() {
       source: ImageSource.camera,
     );
 
+    expect(html.querySelector('flt-image-picker-inputs')?.children.isEmpty,
+        isFalse);
+
     // Mock the browser behavior of selecting a file...
     mockInput.dispatchEvent(html.Event('change'));
 
@@ -68,6 +71,8 @@ void main() {
         completion(
           DateTime.fromMillisecondsSinceEpoch(textFile.lastModified!),
         ));
+    expect(html.querySelector('flt-image-picker-inputs')?.children.isEmpty,
+        isTrue);
   });
 
   testWidgets('getMultiImageWithOptions can select multiple files', (

diff --git a/packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart b/packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart
@@ -158,7 +158,7 @@ class ImagePickerPlugin extends ImagePickerPlatform {
     ) as html.FileUploadInputElement;
     _injectAndActivate(input);
 
-    return _getSelectedXFiles(input);
+    return _getSelectedXFiles(input).whenComplete(input.remove);
   }
 
   // Deprecated methods follow...

diff --git a/packages/image_picker/image_picker_for_web/pubspec.yaml b/packages/image_picker/image_picker_for_web/pubspec.yaml
@@ -2,7 +2,7 @@ name: image_picker_for_web
 description: Web platform implementation of image_picker
 repository: https://github.com/flutter/packages/tree/main/packages/image_picker/image_picker_for_web
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+image_picker%22
-version: 3.0.1
+version: 3.0.2
 
 environment:
   sdk: ">=3.0.0 <4.0.0"