-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[palette_generator] Migrate to null safety #287
Conversation
without it it uses canvas and tests fail (Expected: 'flt-platform-view' Actual: 'div')
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick initial pass, but @gspencergoog should do the full review.
tests are passing
This reverts commit bbb0547 It actually doesn't remove the entry in the nested map.
Continuation of commit: flutter@8495164
Continuation of commit: flutter@0d9a578
is this what was meant? :v
As you mentioned - that's now expressed in the type. This reverts commit 0855080
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything I saw has been addressed; @gspencergoog should definitely do the final review here though since he knows the API.
Looking at it today. |
after this revision all tests except one pass dart:core _AssertionError._throwNew
package:palette_generator/palette_generator.dart 74:16 new PaletteGenerator.fromColors
package:palette_generator/palette_generator.dart 124:29 PaletteGenerator.fromImage
'package:palette_generator/palette_generator.dart': Failed assertion: line 74 pos 16: 'paletteColors.isNotEmpty': is not true. |
Sigh. Conceptually, it should be possible to enforce that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related tracking issue flutter/flutter#75567