[pigeon] Use File.uri over manual URI construction #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `uri` getter works correctly on Windows without the need for extra attention needed to the details of the paths.
|
Sorry, I meant to look into this previously. The problem is that we don't have CI running on windows machines yet and it takes a bit of effort for me to test stuff manually on Windows. That means that despite the fact that you are probably right the barrier to accept changes that aren't addressing bugs is going to be too high. The way it is written now I tested on windows many moons ago. I'll keep this in mind the next time I have to crack open windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
urigetter works correctly on Windows without the need for extraattention needed to the details of the paths.