Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pigeon] add null safety guide to readme #299

Merged
merged 1 commit into from
Mar 19, 2021
Merged

[pigeon] add null safety guide to readme #299

merged 1 commit into from
Mar 19, 2021

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Mar 6, 2021

Replace this paragraph with a description of what this PR is changing or adding, and why.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@fzyzcjy fzyzcjy changed the title add null safety guide to readme [pigeon] add null safety guide to readme Mar 6, 2021
@goderbauer goderbauer requested a review from gaaclarke March 17, 2021 21:42
@gaaclarke
Copy link
Member

I tried to rebase this for you but I don't seem to have permissions. I also tried tweaking the text:

## Null Safety (NNBD)

In order to generate null-safe code run the command line with the extra argument
`--dart_null_safety`. For example:
`flutter pub run pigeon --input ./pigeons/messages.dart --dart_null_safety`.

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Mar 18, 2021

@gaaclarke Hmm so what can I do?

@gaaclarke
Copy link
Member

You need to rebase onto master or give me permissions to push to your PR.

Rebasing will be something like this (its a bit weird because your branch is named master):

git fetch origin
git rebase -i <UPSTREAM REMOTE>/master
# handle conflicts
git add README.md # commit resolution to conflict
git rebase --continue
git push -f <YOUR REMOTE>

@gaaclarke
Copy link
Member

Or if you don't want to deal with it, i can duplicate the change in a different PR.

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Mar 18, 2021

@gaaclarke Sure. Let me rebase it.

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Mar 19, 2021

@gaaclarke Done

@gaaclarke gaaclarke merged commit 7c59510 into flutter:master Mar 19, 2021
stuartmorgan pushed a commit to stuartmorgan/packages that referenced this pull request Apr 30, 2021
stuartmorgan pushed a commit to stuartmorgan/packages that referenced this pull request Apr 30, 2021
austinstoker pushed a commit to austinstoker/packages that referenced this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants