[Android] Introduces API 34 emulators for subset of tests #4820
Conversation
| args: ["build-examples", "--apk"] | ||
| - name: lint | ||
| script: script/tool_runner.sh | ||
| args: ["lint-android"] |
There was a problem hiding this comment.
Since these tasks aren't being passed either of the include/exclude flags, they will all run twice: once on the 34 shards and once on the 33 shards, even though there's no difference.
We should either pass the flags to everything, to keep all the tasks for a given plugin together, and running only in one place, or we should remove these two tasks from the 33 version, so all builds and lints run on the 34 shards.
I would vote for the former, for consistency, but either should work.
| @@ -461,7 +499,7 @@ targets: | |||
| package_sharding: "--shardIndex 5 --shardCount 6" | |||
| dependencies: >- | |||
| [ | |||
| {"dependency": "android_virtual_device", "version": "33"} | |||
| {"dependency": "android_virtual_device", "version": "34"} | |||
| ] | |||
|
|
|||
There was a problem hiding this comment.
You'll need to add matching stable shards, or we'll lose coverage on stable since they are running the same scripts. That can be done in the same prequel PR.
Adds new tasks to create shards to run a subset of Android platform tests on API 33 AVD tests when the update to run tests on AVDs with API 34 lands due to test failures on a subset of plugins. Prequel PR to #4820.
|
This PR is quickly becoming outdated and I have been doing some experimental changes to fix the path provider flake (such as https://ci.chromium.org/ui/p/flutter/builders/try/Linux_android%20android_platform_tests_shard_4%20master/2375/overview). Will fix path provider (#5098) and then open a PR for landing this change. |
Adds new tasks to create shards to run a subset of Android platform tests on API 33 AVD tests when the update to run tests on AVDs with API 34 lands due to test failures on a subset of plugins. Prequel PR to flutter#4820.
Introduces API 34 emulators for subset of tests not causing test failures in flutter#4804. Also changes linux_android version to 34v1. Continuation of flutter#4820.
Introduces API 34 emulators for subset of tests not causing test failures in #4804. Also changes
linux_androidversion to 34v1.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).