-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rfw widgets #5661
Merged
Merged
Add rfw widgets #5661
Changes from 11 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
2599faa
add rfw widgets
peixinli 2fee2ad
add changelog
peixinli ba01940
revert format change
peixinli 77b49b9
add tests
peixinli 61bd40d
add golden file
peixinli 9518814
uncomment runGoldens line
peixinli de5232c
Fix comments and add more test
peixinli e3248a6
Fix comments
peixinli 06b3677
test value type
peixinli d5bcb37
Merge branch 'main' into rfw
peixinli 5f031e1
add rfw widgets
peixinli ad6f552
add changelog
peixinli 74c6c81
revert format change
peixinli 9d00cea
add tests
peixinli 7f8f5f2
add golden file
peixinli 5976859
uncomment runGoldens line
peixinli d67a477
Fix comments and add more test
peixinli 456a887
Fix comments
peixinli 2ec30a2
test value type
peixinli a345557
Merge branch 'flutter:main' into rfw
peixinli 7ac2967
fix comments
peixinli a23eeb1
Merge branch 'flutter:main' into rfw
peixinli 751aedc
Merge branch 'rfw' of https://github.com/peixinli/packages into rfw
peixinli a92cfcd
fix comments
peixinli 372e27f
merge main
peixinli 32b8312
add line
peixinli 43352e7
fix golden
peixinli 53a8a5b
fix web
peixinli 1f1db46
fix
peixinli 16d1253
fix
peixinli e097047
fix
peixinli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,6 +28,7 @@ import 'runtime.dart'; | |
/// * [AspectRatio] | ||
/// * [Center] | ||
/// * [ColoredBox] | ||
/// * [ClipRRect] | ||
peixinli marked this conversation as resolved.
Show resolved
Hide resolved
|
||
/// * [Column] | ||
/// * [Container] (actually uses [AnimatedContainer]) | ||
/// * [DefaultTextStyle] | ||
|
@@ -269,6 +270,15 @@ Map<String, LocalWidgetBuilder> get _coreWidgetsDefinitions => <String, LocalWid | |
); | ||
}, | ||
|
||
'ClipRRect': (BuildContext context, DataSource source) { | ||
return ClipRRect( | ||
borderRadius: ArgumentDecoders.borderRadius(source, ['borderRadius']) ?? BorderRadius.zero, | ||
// clipper, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. looks like the convention for skipped parameters in this file is to give the type as well (see line 441) |
||
clipBehavior: ArgumentDecoders.enumValue<Clip>(Clip.values, source, ['clipBehavior']) ?? Clip.antiAlias, | ||
child: source.optionalChild(['child']), | ||
); | ||
}, | ||
|
||
'ColoredBox': (BuildContext context, DataSource source) { | ||
return ColoredBox( | ||
color: ArgumentDecoders.color(source, ['color']) ?? const Color(0xFF000000), | ||
|
@@ -671,4 +681,4 @@ Map<String, LocalWidgetBuilder> get _coreWidgetsDefinitions => <String, LocalWid | |
); | ||
}, | ||
|
||
}; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should say which ones :-)
remember the old trick when writing documentation: what question is someone trying to answer when reading your prose? what questions will they have after reading your prose?