Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter_markdown] Custom fontfeature superscript #5874

Merged
merged 9 commits into from
Apr 19, 2024
Merged

[flutter_markdown] Custom fontfeature superscript #5874

merged 9 commits into from
Apr 19, 2024

Conversation

dawidope
Copy link
Contributor

Fix not solved issue from another PR: #5058 (comment).

I chose the 2nd option with custom font feature.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@dawidope
Copy link
Contributor Author

dawidope commented Feb 9, 2024

@domesticmouse is there any blocker to merge it?

@domesticmouse
Copy link
Contributor

PTAL @stuartmorgan

tarrinneal
tarrinneal requested changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good with a changelog style update.

packages/flutter_markdown/CHANGELOG.md Outdated Show resolved Hide resolved
@stuartmorgan
Copy link
Contributor

@dawidope Is this PR still something you are planning on updating to make it landable?

@dawidope
Merge branch 'main' into custom_fontfeature_superscript
223bd42 
# Conflicts:
#	packages/flutter_markdown/CHANGELOG.md
#	packages/flutter_markdown/lib/src/style_sheet.dart
#	packages/flutter_markdown/pubspec.yaml
@dawidope
[flutter_markdown] format syntax
6de425e
@dawidope
Copy link
Contributor Author

@stuartmorgan I have done all requested changes. I hope that the changelog follows rules now.

tarrinneal
tarrinneal approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good once you bump the version number and handle the conflicts.

@dawidope
Merge branch 'main' into custom_fontfeature_superscript
b020002 
# Conflicts:
#	packages/flutter_markdown/CHANGELOG.md
#	packages/flutter_markdown/pubspec.yaml
@dawidope
Copy link
Contributor Author

Done. Thanks!

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 19, 2024
@auto-submit auto-submit bot merged commit f630fcd into flutter:main Apr 19, 2024
78 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 22, 2024
@engine-flutter-autoroll
f630fcd [flutter_markdown] Custom fontfeature superscript (flutter/pa…
085475f 
…ckages#5874)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 22, 2024
@engine-flutter-autoroll
Roll Packages from 88a3a56 to 01a32c4 (5 revisions) (#147164)
af439ac 
flutter/packages@88a3a56...01a32c4

2024-04-22 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.2 to 4.1.3 (flutter/packages#6587)
2024-04-21 engine-flutter-autoroll@skia.org Roll Flutter from 98685a0 to 1a905d5 (30 revisions) (flutter/packages#6583)
2024-04-19 dawidope@gmail.com [flutter_markdown] Custom fontfeature superscript (flutter/packages#5874)
2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter from fb110b9 to 98685a0 (28 revisions) (flutter/packages#6577)
2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 300451a to 54e6646 (1 revision) (flutter/packages#6575)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
@engine-flutter-autoroll @gilnobrega
Roll Packages from 88a3a56 to 01a32c4 (5 revisions) (flutter#147164)
8be2a69 
flutter/packages@88a3a56...01a32c4

2024-04-22 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.2 to 4.1.3 (flutter/packages#6587)
2024-04-21 engine-flutter-autoroll@skia.org Roll Flutter from 98685a0 to 1a905d5 (30 revisions) (flutter/packages#6583)
2024-04-19 dawidope@gmail.com [flutter_markdown] Custom fontfeature superscript (flutter/packages#5874)
2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter from fb110b9 to 98685a0 (28 revisions) (flutter/packages#6577)
2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 300451a to 54e6646 (1 revision) (flutter/packages#6575)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@dawidope @TecHaxter
[flutter_markdown] Custom fontfeature superscript (flutter#5874)
4bf050b 
Fix not solved issue from another PR: flutter#5058 (comment).

I chose the 2nd option with custom font feature.
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@dawidope @arc-yong
[flutter_markdown] Custom fontfeature superscript (flutter#5874)
9215488 
Fix not solved issue from another PR: flutter#5058 (comment).

I chose the 2nd option with custom font feature.
@reidbaker reidbaker mentioned this pull request Jul 2, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domesticmouse domesticmouse domesticmouse approved these changes

@tarrinneal tarrinneal tarrinneal approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: flutter_markdown
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dawidope @domesticmouse @stuartmorgan @tarrinneal