Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[video_player_android] Migrate ExoPlayer to ExoPlayer-Media3 1.3.1 #6535

Merged
merged 9 commits into from
Jun 7, 2024

Conversation

emakar
Copy link
Contributor

@emakar emakar commented Apr 15, 2024

Resolves #130272

Migrated with https://developer.android.com/media/media3/exoplayer/migration-guide#usingscript

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@emakar emakar marked this pull request as ready for review April 15, 2024 11:06
@emakar emakar requested a review from camsim99 as a code owner April 15, 2024 11:06
@emakar emakar force-pushed the video_player_android-media3 branch from e33e5a9 to fc005d7 Compare April 15, 2024 11:43
@emakar emakar marked this pull request as draft April 15, 2024 11:44
@emakar emakar force-pushed the video_player_android-media3 branch from fc005d7 to 76a2837 Compare April 15, 2024 12:21
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!! Left a couple of thoughts.

@emakar emakar force-pushed the video_player_android-media3 branch from 76a2837 to 5b0a1cf Compare April 15, 2024 18:19
@emakar emakar changed the title [video_player_android] Migrate ExoPlayer to ExoPlayer-Media3 1.1.1 [video_player_android] Migrate ExoPlayer to ExoPlayer-Media3 1.3.1 Apr 15, 2024
@emakar emakar marked this pull request as draft April 15, 2024 19:05
@emakar emakar force-pushed the video_player_android-media3 branch 5 times, most recently from 222c1a3 to a26491d Compare April 16, 2024 12:30
@emakar emakar force-pushed the video_player_android-media3 branch 4 times, most recently from a6952b6 to eb4fd61 Compare April 16, 2024 17:54
@emakar
Copy link
Contributor Author

emakar commented Jun 6, 2024

Hm, this test is now failing accidentally

══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: a value greater than Duration:<0:00:00.000000>
  Actual: Duration:<0:00:00.000000>
   Which: is not a value greater than Duration:<0:00:00.000000>

When the exception was thrown, this was the stack:
#4      main.<anonymous closure>.<anonymous closure> (file:///b/s/w/ir/x/w/packages/packages/video_player/video_player_android/example/integration_test/video_player_test.dart:71:7)
<asynchronous suspension>
#5      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:183:15)
<asynchronous suspension>
#6      TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:1025:5)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)

This was caught by the test expectation on the following line:
  file:///b/s/w/ir/x/w/packages/packages/video_player/video_player_android/example/integration_test/video_player_test.dart line 71
The test description was:
  can be played

@emakar emakar force-pushed the video_player_android-media3 branch from ef48514 to 78b87ee Compare June 6, 2024 09:56
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the iteration on this to put the plugin on a more stable API foundation!

A couple of minor comments, and @camsim99 will need to re-review as well, but this has my LGTM.

@emakar emakar force-pushed the video_player_android-media3 branch 2 times, most recently from aa4c94b to 1ef9058 Compare June 6, 2024 21:14
@emakar
Copy link
Contributor Author

emakar commented Jun 6, 2024

thanks for the review!

@camsim99 camsim99 self-requested a review June 6, 2024 21:42
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emakar emakar force-pushed the video_player_android-media3 branch from 1ef9058 to 14409b8 Compare June 7, 2024 07:56
@emakar emakar force-pushed the video_player_android-media3 branch from 14409b8 to a134c80 Compare June 7, 2024 08:14
@emakar
Copy link
Contributor Author

emakar commented Jun 7, 2024

@camsim99 could you please review this?

Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 7, 2024
@auto-submit auto-submit bot merged commit 14722b7 into flutter:main Jun 7, 2024
74 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 10, 2024
flutter/packages@8a2c4e4...e95fe4a

2024-06-07 engine-flutter-autoroll@skia.org Manual roll Flutter from 4608a89 to fc19ecf (38 revisions) (flutter/packages#6890)
2024-06-07 stuartmorgan@google.com [pigeon] Fix handling of null class args in C++ (flutter/packages#6881)
2024-06-07 eugene.makar@yandex.ru [video_player_android] Migrate ExoPlayer to ExoPlayer-Media3 1.3.1 (flutter/packages#6535)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: video_player platform-android triage-android Should be looked at in Android triage
Projects
None yet
6 participants