-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[video_player_android] Migrate ExoPlayer to ExoPlayer-Media3 1.3.1 #6535
Conversation
e33e5a9
to
fc005d7
Compare
fc005d7
to
76a2837
Compare
packages/video_player/video_player_android/android/build.gradle
Outdated
Show resolved
Hide resolved
packages/video_player/video_player_android/android/build.gradle
Outdated
Show resolved
Hide resolved
...r/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!! Left a couple of thoughts.
...r/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java
Outdated
Show resolved
Hide resolved
packages/video_player/video_player_android/android/build.gradle
Outdated
Show resolved
Hide resolved
packages/video_player/video_player_android/android/build.gradle
Outdated
Show resolved
Hide resolved
76a2837
to
5b0a1cf
Compare
222c1a3
to
a26491d
Compare
packages/video_player/video_player_android/android/build.gradle
Outdated
Show resolved
Hide resolved
a6952b6
to
eb4fd61
Compare
...r/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java
Outdated
Show resolved
Hide resolved
Hm, this test is now failing accidentally
|
...r/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java
Outdated
Show resolved
Hide resolved
ef48514
to
78b87ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the iteration on this to put the plugin on a more stable API foundation!
A couple of minor comments, and @camsim99 will need to re-review as well, but this has my LGTM.
...r/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java
Outdated
Show resolved
Hide resolved
...r/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java
Outdated
Show resolved
Hide resolved
aa4c94b
to
1ef9058
Compare
thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
...r/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java
Outdated
Show resolved
Hide resolved
1ef9058
to
14409b8
Compare
14409b8
to
a134c80
Compare
@camsim99 could you please review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
flutter/packages@8a2c4e4...e95fe4a 2024-06-07 engine-flutter-autoroll@skia.org Manual roll Flutter from 4608a89 to fc19ecf (38 revisions) (flutter/packages#6890) 2024-06-07 stuartmorgan@google.com [pigeon] Fix handling of null class args in C++ (flutter/packages#6881) 2024-06-07 eugene.makar@yandex.ru [video_player_android] Migrate ExoPlayer to ExoPlayer-Media3 1.3.1 (flutter/packages#6535) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Resolves #130272
Migrated with https://developer.android.com/media/media3/exoplayer/migration-guide#usingscript
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.md
to add a description of the change, [following repository CHANGELOG style].///
).