Ensure each code block specified in the markdown uses its own ScrollController. #6904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domesticmouse
approved these changes
Jun 11, 2024
|
PTAL @stuartmorgan |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 11, 2024
… ScrollController. (flutter/packages#6904)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 11, 2024
… ScrollController. (flutter/packages#6904)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 12, 2024
flutter/packages@e95fe4a...8c24fd4 2024-06-11 engine-flutter-autoroll@skia.org Roll Flutter from 32081aa to 14df7be (21 revisions) (flutter/packages#6907) 2024-06-11 luthien256@gmail.com Ensure each code block specified in the markdown uses its own ScrollController. (flutter/packages#6904) 2024-06-10 stuartmorgan@google.com [video_player] Try to address test flake (flutter/packages#6899) 2024-06-10 stuartmorgan@google.com [ci] Allow `platform` references (flutter/packages#6903) 2024-06-10 magder@google.com Change CODEOWNERS for metrics_center (flutter/packages#6892) 2024-06-10 mit@google.com Remove package:platform source (flutter/packages#6898) 2024-06-10 engine-flutter-autoroll@skia.org Roll Flutter from fc19ecf to 32081aa (9 revisions) (flutter/packages#6896) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…ontroller. (flutter#6904) Currently all code blocks share the same ScrollController causing an exception when they appear on screen together. This fixes that situation.
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
flutter/packages@e95fe4a...8c24fd4 2024-06-11 engine-flutter-autoroll@skia.org Roll Flutter from 32081aa to 14df7be (21 revisions) (flutter/packages#6907) 2024-06-11 luthien256@gmail.com Ensure each code block specified in the markdown uses its own ScrollController. (flutter/packages#6904) 2024-06-10 stuartmorgan@google.com [video_player] Try to address test flake (flutter/packages#6899) 2024-06-10 stuartmorgan@google.com [ci] Allow `platform` references (flutter/packages#6903) 2024-06-10 magder@google.com Change CODEOWNERS for metrics_center (flutter/packages#6892) 2024-06-10 mit@google.com Remove package:platform source (flutter/packages#6898) 2024-06-10 engine-flutter-autoroll@skia.org Roll Flutter from fc19ecf to 32081aa (9 revisions) (flutter/packages#6896) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
flutter/packages@e95fe4a...8c24fd4 2024-06-11 engine-flutter-autoroll@skia.org Roll Flutter from 32081aa to 14df7be (21 revisions) (flutter/packages#6907) 2024-06-11 luthien256@gmail.com Ensure each code block specified in the markdown uses its own ScrollController. (flutter/packages#6904) 2024-06-10 stuartmorgan@google.com [video_player] Try to address test flake (flutter/packages#6899) 2024-06-10 stuartmorgan@google.com [ci] Allow `platform` references (flutter/packages#6903) 2024-06-10 magder@google.com Change CODEOWNERS for metrics_center (flutter/packages#6892) 2024-06-10 mit@google.com Remove package:platform source (flutter/packages#6898) 2024-06-10 engine-flutter-autoroll@skia.org Roll Flutter from fc19ecf to 32081aa (9 revisions) (flutter/packages#6896) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all code blocks share the same ScrollController causing an exception when they appear on screen together. This fixes that situation.