[video_player] Relands #6456: Uses `SurfaceProducer`, this time with `setCallback` for suspend/resume lifecycles. #6989

matanlurey · 2024-06-25T22:05:00Z

/cc @jonahwilliams @chinmaygarde @johnmccutchan.

…further-refactor

…surface-producer-redo

jonahwilliams

Does phone rotation impact the exo video? Are there ways to configure video player to play a video from a hardware device (camera?) that would require rotation?

matanlurey · 2024-06-28T23:50:15Z

As mentioned offline, I'll need to merge this into a preview branch (maybe just impeller) until the next stable.

@stuartmorgan @camsim99 Would you prefer I either:

Merge all of the changes that can land right now, i.e. break this into two PRs.
Not bother, and instead merge against a new impeller branch.

stuartmorgan · 2024-07-01T14:21:56Z

I don't have an opinion; I'll leave it to the Android folks who are the primary maintainers of the Java code.

camsim99 · 2024-07-01T15:10:27Z

I have no strong preference but breaking into two PRs may be easier for packages contributors to follow, as I'd assume we'd otherwise need to document the impeller branch somewhere for them to be aware.

…d-surface-producer-redo

matanlurey · 2024-08-22T18:48:47Z

Ping @camsim99 @gmackall I think this is ready to land (modulo repo checks), could you do a final LGTM?

camsim99

At a high level this LGTM!! There is a synthetic accessor lint error though

…this time with `setCallback` for suspend/resume lifecycles. (flutter#6989)" This reverts commit 62b4cb0.

… with setCallback for suspend/resume lifecycles" (#7497) Reverts #6989 Fixes flutter/flutter#154054 , flutter/flutter#154050

…this time with `setCallback` for suspend/resume lifecycles. (flutter/packages#6989)

flutter/packages@d862279...2a0f254 2024-08-28 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for remaining methods of the Android native `AdsManager` (flutter/packages#7437) 2024-08-28 brackenavaron@gmail.com [shared_preferences] Fix typo in changelog (flutter/packages#7523) 2024-08-27 matanlurey@users.noreply.github.com Remove matan from codeowners (flutter/packages#7511) 2024-08-27 tarrinneal@gmail.com [shared_preferences] Add test to enforce mutable lists (flutter/packages#7369) 2024-08-27 magder@google.com [google_sign_in_ios] Fix "callee requires a non-null parameter" analyzer warning (flutter/packages#7513) 2024-08-27 louisehsu@google.com [in_app_purchase_storekit] Allows 'localizedDescription' to be nullable to handle occasional nulls in Storekit objects (flutter/packages#7515) 2024-08-27 31859944+LongCatIsLooong@users.noreply.github.com Cupertino icons golden tests (flutter/packages#7421) 2024-08-26 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.10 to 2.0.20 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7500) 2024-08-26 zezohassam@gmail.com [video_player] Updates minimum supported SDK (flutter/packages#7498) 2024-08-26 paulberry@google.com [url_launcher] Ignore new `unreachable_switch_default` warning. (flutter/packages#7487) 2024-08-26 linxunfeng@yeah.net Revert "[video_player] Relands #6456: Uses SurfaceProducer, this time with setCallback for suspend/resume lifecycles" (flutter/packages#7497) 2024-08-24 matanlurey@users.noreply.github.com [video_player] Relands #6456: Uses `SurfaceProducer`, this time with `setCallback` for suspend/resume lifecycles. (flutter/packages#6989) 2024-08-23 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `PlatformTileOverlay` to Pigeon (flutter/packages#7467) 2024-08-23 47866232+chunhtai@users.noreply.github.com [go_router] Fixes issue so that the parseRouteInformationWithContext â�¦ (flutter/packages#7337) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/packages@d862279...2a0f254 2024-08-28 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for remaining methods of the Android native `AdsManager` (flutter/packages#7437) 2024-08-28 brackenavaron@gmail.com [shared_preferences] Fix typo in changelog (flutter/packages#7523) 2024-08-27 matanlurey@users.noreply.github.com Remove matan from codeowners (flutter/packages#7511) 2024-08-27 tarrinneal@gmail.com [shared_preferences] Add test to enforce mutable lists (flutter/packages#7369) 2024-08-27 magder@google.com [google_sign_in_ios] Fix "callee requires a non-null parameter" analyzer warning (flutter/packages#7513) 2024-08-27 louisehsu@google.com [in_app_purchase_storekit] Allows 'localizedDescription' to be nullable to handle occasional nulls in Storekit objects (flutter/packages#7515) 2024-08-27 31859944+LongCatIsLooong@users.noreply.github.com Cupertino icons golden tests (flutter/packages#7421) 2024-08-26 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.10 to 2.0.20 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7500) 2024-08-26 zezohassam@gmail.com [video_player] Updates minimum supported SDK (flutter/packages#7498) 2024-08-26 paulberry@google.com [url_launcher] Ignore new `unreachable_switch_default` warning. (flutter/packages#7487) 2024-08-26 linxunfeng@yeah.net Revert "[video_player] Relands flutter#6456: Uses SurfaceProducer, this time with setCallback for suspend/resume lifecycles" (flutter/packages#7497) 2024-08-24 matanlurey@users.noreply.github.com [video_player] Relands flutter#6456: Uses `SurfaceProducer`, this time with `setCallback` for suspend/resume lifecycles. (flutter/packages#6989) 2024-08-23 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `PlatformTileOverlay` to Pigeon (flutter/packages#7467) 2024-08-23 47866232+chunhtai@users.noreply.github.com [go_router] Fixes issue so that the parseRouteInformationWithContext â�¦ (flutter/packages#7337) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Gustl22 · 2024-10-11T11:27:28Z

Relanded in #7498

matanlurey added 11 commits June 24, 2024 21:27

Further refactor and add test coverage for video_player_android.

fea9087

Merge remote-tracking branch 'origin/main' into video-player-android-…

eb5be68

…further-refactor

++ for draft review.

892115e

Javafmt.

deb7d4b

Address android_lint.

e0f663c

Add back missing gradle dependency thingy.

796fedc

Address feedback.

0516633

Revert pubspec override.

9bd2beb

Add resume/suspend using the new SurfaceProducer.Callback APIs.

3dd75ec

Merge remote-tracking branch 'origin/main' into video-player-android-…

65c080e

…surface-producer-redo

Fmt.

a1dfdcf

matanlurey requested a review from gmackall June 25, 2024 22:05

matanlurey requested a review from camsim99 as a code owner June 25, 2024 22:05

github-actions bot added platform-android p: video_player labels Jun 25, 2024

jonahwilliams reviewed Jun 25, 2024

View reviewed changes

matanlurey mentioned this pull request Jun 26, 2024

VideoPlayer failed to auto-rotate the video after upgrade flutter to version 3.22.0. flutter/flutter#149556

Closed

stuartmorgan changed the title ~~Relands #6456: Uses SurfaceProducer, this time with setCallback for suspend/resume lifecycles.~~ [video_player] Relands #6456: Uses SurfaceProducer, this time with setCallback for suspend/resume lifecycles. Jul 1, 2024

This comment was marked as outdated.

Sign in to view

matanlurey added 2 commits August 22, 2024 11:36

Merge remote-tracking branch 'upstream/main' into video-player-androi…

0e8ddac

…d-surface-producer-redo

Delint and stuff.

3d7bc67

matanlurey force-pushed the video-player-android-surface-producer-redo branch from 56eb1d1 to 3d7bc67 Compare August 22, 2024 18:48

camsim99 approved these changes Aug 22, 2024

View reviewed changes

matanlurey added 3 commits August 22, 2024 14:57

Delint.

064d40f

Try another approach.

b07e1e2

++

cd573f1

matanlurey force-pushed the video-player-android-surface-producer-redo branch from 231b774 to f770bdb Compare August 23, 2024 19:06

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 23, 2024

matanlurey mentioned this pull request Aug 23, 2024

Migrate rendering plugins to SurfaceProducer after stable release flutter/flutter#139702

Closed

7 tasks

auto-submit bot merged commit 62b4cb0 into main Aug 24, 2024
76 checks passed

auto-submit bot deleted the video-player-android-surface-producer-redo branch August 24, 2024 01:48

This was referenced Aug 25, 2024

Android impller support media-kit/media-kit#707

Closed

Build Failure due to Missing SurfaceProducer.Callback in video_player_android Plugin flutter/flutter#154054

Closed

LinXunFeng added a commit to LinXunFeng/packages that referenced this pull request Aug 26, 2024

Revert "[video_player] Relands flutter#6456: Uses SurfaceProducer, …

43b106a

…this time with `setCallback` for suspend/resume lifecycles. (flutter#6989)" This reverts commit 62b4cb0.

LinXunFeng mentioned this pull request Aug 26, 2024

Revert "[video_player] Relands #6456: Uses SurfaceProducer, this time with setCallback for suspend/resume lifecycles" #7497

Merged

auto-submit bot pushed a commit that referenced this pull request Aug 26, 2024

Revert "[video_player] Relands #6456: Uses SurfaceProducer, this time…

f61a98a

… with setCallback for suspend/resume lifecycles" (#7497) Reverts #6989 Fixes flutter/flutter#154054 , flutter/flutter#154050

engine-flutter-autoroll mentioned this pull request Aug 26, 2024

Roll Packages from d862279f291f to 6c12c88544a7 (5 revisions) flutter/flutter#154110

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 26, 2024

62b4cb0 [video_player] Relands flutter#6456: Uses SurfaceProducer, …

1d1dee0

…this time with `setCallback` for suspend/resume lifecycles. (flutter/packages#6989)

engine-flutter-autoroll mentioned this pull request Aug 26, 2024

Roll Packages from d862279f291f to a0501f2e2a50 (6 revisions) flutter/flutter#154117

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 26, 2024

62b4cb0 [video_player] Relands flutter#6456: Uses SurfaceProducer, …

a419753

…this time with `setCallback` for suspend/resume lifecycles. (flutter/packages#6989)

engine-flutter-autoroll mentioned this pull request Aug 26, 2024

Roll Packages from d862279f291f to b9715b7eac7d (7 revisions) flutter/flutter#154122

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 26, 2024

62b4cb0 [video_player] Relands flutter#6456: Uses SurfaceProducer, …

8a200bf

…this time with `setCallback` for suspend/resume lifecycles. (flutter/packages#6989)

engine-flutter-autoroll mentioned this pull request Aug 27, 2024

Roll Packages from d862279f291f to b9715b7eac7d (7 revisions) flutter/flutter#154180

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 27, 2024

62b4cb0 [video_player] Relands flutter#6456: Uses SurfaceProducer, …

b6a57dc

…this time with `setCallback` for suspend/resume lifecycles. (flutter/packages#6989)

engine-flutter-autoroll mentioned this pull request Aug 27, 2024

Roll Packages from d862279f291f to ef81058368d6 (8 revisions) flutter/flutter#154191

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 27, 2024

62b4cb0 [video_player] Relands flutter#6456: Uses SurfaceProducer, …

2a48731

…this time with `setCallback` for suspend/resume lifecycles. (flutter/packages#6989)

engine-flutter-autoroll mentioned this pull request Aug 28, 2024

Roll Packages from d862279f291f to cc7b5fc79cd3 (12 revisions) flutter/flutter#154259

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 28, 2024

62b4cb0 [video_player] Relands flutter#6456: Uses SurfaceProducer, …

4d8ad33

…this time with `setCallback` for suspend/resume lifecycles. (flutter/packages#6989)

engine-flutter-autoroll mentioned this pull request Aug 28, 2024

Roll Packages from d862279f291f to cc7b5fc79cd3 (12 revisions) flutter/flutter#154277

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 28, 2024

62b4cb0 [video_player] Relands flutter#6456: Uses SurfaceProducer, …

bcb7add

…this time with `setCallback` for suspend/resume lifecycles. (flutter/packages#6989)

engine-flutter-autoroll mentioned this pull request Aug 29, 2024

Roll Packages from d862279f291f to 2a0f25419c52 (14 revisions) flutter/flutter#154341

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 29, 2024

62b4cb0 [video_player] Relands flutter#6456: Uses SurfaceProducer, …

25e38d7

…this time with `setCallback` for suspend/resume lifecycles. (flutter/packages#6989)

camsim99 mentioned this pull request Sep 5, 2024

[camerax] Add fix for camera preview rotation on landscape-oriented devices and set up fix for Impeller support #7044

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[video_player] Relands #6456: Uses `SurfaceProducer`, this time with `setCallback` for suspend/resume lifecycles. #6989

[video_player] Relands #6456: Uses `SurfaceProducer`, this time with `setCallback` for suspend/resume lifecycles. #6989

matanlurey commented Jun 25, 2024 •

edited

Loading

jonahwilliams left a comment

matanlurey commented Jun 28, 2024

stuartmorgan commented Jul 1, 2024

camsim99 commented Jul 1, 2024 via email •

edited

Loading

This comment was marked as outdated.

matanlurey commented Aug 22, 2024

camsim99 left a comment

Gustl22 commented Oct 11, 2024

[video_player] Relands #6456: Uses SurfaceProducer, this time with setCallback for suspend/resume lifecycles. #6989

[video_player] Relands #6456: Uses SurfaceProducer, this time with setCallback for suspend/resume lifecycles. #6989

Conversation

matanlurey commented Jun 25, 2024 • edited Loading

jonahwilliams left a comment

Choose a reason for hiding this comment

matanlurey commented Jun 28, 2024

stuartmorgan commented Jul 1, 2024

camsim99 commented Jul 1, 2024 via email • edited Loading

This comment was marked as outdated.

matanlurey commented Aug 22, 2024

camsim99 left a comment

Choose a reason for hiding this comment

Gustl22 commented Oct 11, 2024

[video_player] Relands #6456: Uses `SurfaceProducer`, this time with `setCallback` for suspend/resume lifecycles. #6989

[video_player] Relands #6456: Uses `SurfaceProducer`, this time with `setCallback` for suspend/resume lifecycles. #6989

matanlurey commented Jun 25, 2024 •

edited

Loading

camsim99 commented Jul 1, 2024 via email •

edited

Loading