-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[webview_flutter_wkwebview] Support NTLM for authentication #7670
Conversation
Sorry for the delay reviewing this. There was a timeout in one of the tests, I merged in main to run them again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jenn Magder <magder@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
flutter/packages@bb00d34...8fbf4cd 2024-10-08 engine-flutter-autoroll@skia.org Manual roll Flutter from 0975e61 to ec2e12b (54 revisions) (flutter/packages#7815) 2024-10-08 engine-flutter-autoroll@skia.org Manual roll Flutter from 6bba08c to 0975e61 (1 revision) (flutter/packages#7814) 2024-10-08 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.7 to 4.2.1 (flutter/packages#7813) 2024-10-08 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds remaining methods for internal wrapper of the iOS native `IMAAdsRenderingSettings` (flutter/packages#7745) 2024-10-08 stuartmorgan@google.com [url_launcher] Remove incorrect SMS instructions (flutter/packages#7807) 2024-10-08 engine-flutter-autoroll@skia.org Manual roll Flutter from ead6b0d to 6bba08c (37 revisions) (flutter/packages#7809) 2024-10-07 jtanium@gmail.com [webview_flutter_wkwebview] Support NTLM for authentication (flutter/packages#7670) 2024-10-07 stuartmorgan@google.com Revert "[in_app_purchase_storekit] Add support for purchase and transactions" (flutter/packages#7810) 2024-10-07 louisehsu@google.com [in_app_purchase_storekit] Add support for purchase and transactions (flutter/packages#7574) 2024-10-07 engine-flutter-autoroll@skia.org Manual roll Flutter from fa402c8 to ead6b0d (14 revisions) (flutter/packages#7806) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This change allows wkwebview to support NTLM on iOS.
#155427
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.