-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[various] Adds macOS privacy manifests #7687
Conversation
macOS privacy manifest enforcement is rolling out soon, so this brings all macOS plugins into alignment with our iOS policy of always having a manifest, including updating the repo tooling to enforce that. Very few plugins are affected because most share the implementation package with iOS, and we didn't do any target platform switching when adding the manifests for iOS, automatically covering macOS as well. Fixes flutter/flutter#155564
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Thanks for catching it proactively! I forgot we hadn't done both platforms together so I wouldn't have thought of it (until someone reported getting rejected for |
auto label is removed for flutter/packages/7687, due to - The status or check suite Linux_android android_device_tests_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/packages@9de72be...4926c0f 2024-09-24 43054281+camsim99@users.noreply.github.com [quick_actions] Add guidance for correcting task management/back press behavior for apps with launcher activities (flutter/packages#7686) 2024-09-24 stuartmorgan@google.com [various] Adds macOS privacy manifests (flutter/packages#7687) 2024-09-23 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `PlatformPolyline.pattern` to Pigeon (flutter/packages#7631) 2024-09-23 engine-flutter-autoroll@skia.org Roll Flutter from 2f149da to 4ca51a1 (5 revisions) (flutter/packages#7685) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@9de72be...4926c0f 2024-09-24 43054281+camsim99@users.noreply.github.com [quick_actions] Add guidance for correcting task management/back press behavior for apps with launcher activities (flutter/packages#7686) 2024-09-24 stuartmorgan@google.com [various] Adds macOS privacy manifests (flutter/packages#7687) 2024-09-23 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `PlatformPolyline.pattern` to Pigeon (flutter/packages#7631) 2024-09-23 engine-flutter-autoroll@skia.org Roll Flutter from 2f149da to 4ca51a1 (5 revisions) (flutter/packages#7685) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@9de72be...4926c0f 2024-09-24 43054281+camsim99@users.noreply.github.com [quick_actions] Add guidance for correcting task management/back press behavior for apps with launcher activities (flutter/packages#7686) 2024-09-24 stuartmorgan@google.com [various] Adds macOS privacy manifests (flutter/packages#7687) 2024-09-23 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `PlatformPolyline.pattern` to Pigeon (flutter/packages#7631) 2024-09-23 engine-flutter-autoroll@skia.org Roll Flutter from 2f149da to 4ca51a1 (5 revisions) (flutter/packages#7685) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@9de72be...4926c0f 2024-09-24 43054281+camsim99@users.noreply.github.com [quick_actions] Add guidance for correcting task management/back press behavior for apps with launcher activities (flutter/packages#7686) 2024-09-24 stuartmorgan@google.com [various] Adds macOS privacy manifests (flutter/packages#7687) 2024-09-23 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `PlatformPolyline.pattern` to Pigeon (flutter/packages#7631) 2024-09-23 engine-flutter-autoroll@skia.org Roll Flutter from 2f149da to 4ca51a1 (5 revisions) (flutter/packages#7685) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@9de72be...4926c0f 2024-09-24 43054281+camsim99@users.noreply.github.com [quick_actions] Add guidance for correcting task management/back press behavior for apps with launcher activities (flutter/packages#7686) 2024-09-24 stuartmorgan@google.com [various] Adds macOS privacy manifests (flutter/packages#7687) 2024-09-23 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `PlatformPolyline.pattern` to Pigeon (flutter/packages#7631) 2024-09-23 engine-flutter-autoroll@skia.org Roll Flutter from 2f149da to 4ca51a1 (5 revisions) (flutter/packages#7685) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
macOS privacy manifest enforcement is rolling out soon, so this brings all macOS plugins into alignment with our iOS policy of always having a manifest, including updating the repo tooling to enforce that.
Very few plugins are affected because most share the implementation package with iOS, and we didn't do any target platform switching when adding the manifests for iOS, automatically covering macOS as well.
Fixes flutter/flutter#155564
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).