Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose the ExoPlayer before SurfaceProducer. #7824

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Oct 8, 2024

Fixes 1 of the 2 reported issues in flutter/flutter#156158 (dispose)

I'd like to write a better (integration) test for this (flutter/flutter#156424), but honestly this should have been caught by existing tests (which call dispose). I am asking on Discord for more clarification.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2024
Copy link
Contributor

auto-submit bot commented Oct 8, 2024

auto label is removed for flutter/packages/7824, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@matanlurey matanlurey merged commit 0d009ee into main Oct 8, 2024
76 checks passed
@matanlurey matanlurey deleted the video_player_android-releaseCrasher branch October 8, 2024 20:42
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 9, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 9, 2024
flutter/packages@8fbf4cd...9d00fb1

2024-10-09 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for Android native `CompanionAd` (flutter/packages#7823)
2024-10-08 matanlurey@users.noreply.github.com Disable `SurfaceProducer.Callback` when the surface is disposed manually. (flutter/packages#7827)
2024-10-08 matanlurey@users.noreply.github.com Dispose the `ExoPlayer` before `SurfaceProducer`. (flutter/packages#7824)
2024-10-08 stuartmorgan@google.com [pigeon] Use non-nullable generics in example app (flutter/packages#7817)
2024-10-08 43054281+camsim99@users.noreply.github.com Manually Roll Flutter (stable) from 4cf269e to 2663184 (5 revisions) (flutter/packages#7819)
2024-10-08 stuartmorgan@google.com [camera] Update iOS Pigeon for non-nullable generics (flutter/packages#7787)
2024-10-08 stuartmorgan@google.com [in_app_purchase] Update Android Pigeon for non-nullable generics (flutter/packages#7788)
2024-10-08 jessiewong401@gmail.com [WIP] Updated applying gradle plugin for flutter_plugin_android_lifecycles (flutter/packages#7786)
2024-10-08 engine-flutter-autoroll@skia.org Manual roll Flutter from ec2e12b to 0917e9d (29 revisions) (flutter/packages#7816)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants