Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[video_player_android] Give can pause integration test range to test for #7913

Merged
merged 10 commits into from
Oct 23, 2024
Merged

[video_player_android] Give can pause integration test range to test for #7913

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
95b9477
Add diff
camsim99 Oct 22, 2024
e27fe44
Bump diff
camsim99 Oct 22, 2024
13bb6cf
Fix units
camsim99 Oct 23, 2024
1898dba
Change diff from s to ms
camsim99 Oct 23, 2024
b89f0f9
Increase diff
camsim99 Oct 23, 2024
27eaff2
Increase diff
camsim99 Oct 23, 2024
da0efeb
Bump version
camsim99 Oct 23, 2024
280fef6
Add back missing pump and settle
camsim99 Oct 23, 2024
b5215c7
undo changelog and versioning
camsim99 Oct 23, 2024
9de058a
undo todo
camsim99 Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/video_player/video_player_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.7.16

* Modifies `can pause` integration test to account for asynchronous pausing.

## 2.7.15

* Changes the rotation correction calculation for Android API 29+ to use
Expand Down
4 changes: 3 additions & 1 deletion packages/video_player/video_player_android/example/integration_test/video_player_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,9 @@ void main() {
final Duration pausedDuration = await player.getPosition(textureId);
await tester.pumpAndSettle(_playDuration);

expect(await player.getPosition(textureId), pausedDuration);
// TODO(camsim99): Implement reliable way to tell when pausing completes
// to check for exact pausedDuration.
expect((await player.getPosition(textureId)).inMilliseconds, inInclusiveRange(pausedDuration.inMilliseconds, pausedDuration.inMilliseconds + 500));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am legit confused why this is necessary, the original code (before the refactor) read:

      await controller.initialize();

      // Play for a second, then pause, and then wait a second.
      await controller.play();
      await tester.pumpAndSettle(_playDuration);
      await controller.pause();
      await tester.pumpAndSettle(_playDuration);
      final Duration pausedPosition = (await controller.position)!;
      await tester.pumpAndSettle(_playDuration);

      // Verify that we stopped playing after the pause.
      expect(await controller.position, pausedPosition);

Maybe that intermediate pumpAndSettle is necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I didn't realize we removed one! Added it back to see.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! That was my bad as well, I wish there was an easy to way run a test 100 times.

await player.dispose(textureId);
});

Expand Down
2 changes: 1 addition & 1 deletion packages/video_player/video_player_android/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: video_player_android
description: Android implementation of the video_player plugin.
repository: https://github.com/flutter/packages/tree/main/packages/video_player/video_player_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22
version: 2.7.15
version: 2.7.16

environment:
sdk: ^3.5.0
Expand Down