Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable two lint rules which are being removed. #7959

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

srawlins
Copy link
Contributor

Each of these are going to be removed soon.

  • avoid_null_checks_in_equality_operators
  • unsafe_html

Work towards dart-lang/sdk#59514 and dart-lang/sdk#57099

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Each of these are going to be removed soon.

* avoid_null_checks_in_equality_operators
* unsafe_html

Work towards https://github.com/dart-lang/linter/issues/5063 and https://github.com/dart-lang/linter/issues/5001
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! /cc @stuartmorgan FYI!

@srawlins srawlins added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 30, 2024
@auto-submit auto-submit bot merged commit e12e073 into flutter:main Oct 30, 2024
76 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2024
@srawlins srawlins mentioned this pull request Nov 15, 2024
15 tasks
@srawlins srawlins deleted the no-lint-rules branch October 30, 2024 15:50
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 30, 2024
flutter/packages@028027e...7cc1caa

2024-10-30 stuartmorgan@google.com [tool] Update build-all app creation (flutter/packages#7955)
2024-10-30 srawlins@google.com Disable two lint rules which are being removed. (flutter/packages#7959)
2024-10-29 matanlurey@users.noreply.github.com Bump `path_provider_android` to `^2.2.5` due to Android v1 embedder. (flutter/packages#7935)
2024-10-29 engine-flutter-autoroll@skia.org Roll Flutter from 3fb95c7 to 42132e8 (19 revisions) (flutter/packages#7958)
2024-10-29 stuartmorgan@google.com [webview_flutter] Fix macOS 14+ test hangs (flutter/packages#7953)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants