Add logger

flutter · Jan 22, 2021 · 6ef2634 · 6ef2634
1 parent faa26ec
commit 6ef2634
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 3 deletions.
diff --git a/packages/file_selector/file_selector/example/lib/open_text_page.dart b/packages/file_selector/file_selector/example/lib/open_text_page.dart
@@ -8,7 +8,7 @@ class OpenTextPage extends StatelessWidget {
       label: 'text',
       extensions: ['txt', 'json'],
     );
-    final XFile file = await openFile(acceptedTypeGroups: [typeGroup]);
+    final XFile file = await openFile();
     final String fileName = file.name;
     final String fileContent = await file.readAsString();
 

diff --git a/packages/file_selector/file_selector/lib/file_selector.dart b/packages/file_selector/file_selector/lib/file_selector.dart
@@ -3,18 +3,20 @@
 // found in the LICENSE file.
 
 import 'dart:async';
-
+import 'package:logger/logger.dart';
 import 'package:file_selector_platform_interface/file_selector_platform_interface.dart';
-
 export 'package:file_selector_platform_interface/file_selector_platform_interface.dart'
     show XFile, XTypeGroup;
 
+final _logger = Logger();
+
 /// Open file dialog for loading files and return a file path
 Future<XFile> openFile({
   List<XTypeGroup> acceptedTypeGroups,
   String initialDirectory,
   String confirmButtonText,
 }) {
+  _verifyExtensions(acceptedTypeGroups);
   return FileSelectorPlatform.instance.openFile(
       acceptedTypeGroups: acceptedTypeGroups,
       initialDirectory: initialDirectory,
@@ -27,6 +29,7 @@ Future<List<XFile>> openFiles({
   String initialDirectory,
   String confirmButtonText,
 }) {
+  _verifyExtensions(acceptedTypeGroups);
   return FileSelectorPlatform.instance.openFiles(
       acceptedTypeGroups: acceptedTypeGroups,
       initialDirectory: initialDirectory,
@@ -40,6 +43,7 @@ Future<String> getSavePath({
   String suggestedName,
   String confirmButtonText,
 }) async {
+  _verifyExtensions(acceptedTypeGroups);
   return FileSelectorPlatform.instance.getSavePath(
       acceptedTypeGroups: acceptedTypeGroups,
       initialDirectory: initialDirectory,
@@ -55,3 +59,16 @@ Future<String> getDirectoryPath({
   return FileSelectorPlatform.instance.getDirectoryPath(
       initialDirectory: initialDirectory, confirmButtonText: confirmButtonText);
 }
+
+void _verifyExtensions(List<XTypeGroup> acceptedTypeGroups) {
+  acceptedTypeGroups?.asMap()?.forEach((i, acceptedTypeGroup) {
+    acceptedTypeGroup.extensions?.asMap()?.forEach((j, ext) {
+      if (ext.startsWith('.')) {
+        _logger.w(
+          'acceptedTypeGroups[${i}].extensions[${j}] with value "${ext}" is invalid.'
+          ' Remove the leading dot.',
+        );
+      }
+    });
+  });
+}
diff --git a/packages/file_selector/file_selector/pubspec.yaml b/packages/file_selector/file_selector/pubspec.yaml
@@ -7,6 +7,7 @@ dependencies:
   flutter:
     sdk: flutter
   file_selector_platform_interface: ^1.0.0
+  logger: ^0.9.4
 
 dev_dependencies:
   flutter_test: