address review comments

flutter · May 30, 2022 · ba3321d · ba3321d
1 parent 95259ee
commit ba3321d
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 5 deletions.
diff --git a/packages/webview_flutter/webview_flutter_platform_interface/CHANGELOG.md b/packages/webview_flutter/webview_flutter_platform_interface/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 1.9.1
+
+* Fixes unnecessary imports after [adding some exports of public API in foundation/serialization.dart](https://github.com/flutter/flutter/pull/104231).
+
 ## 1.9.0
 
 * Adds the first iteration of the v4 webview_flutter interface implementation.

diff --git a/...view_flutter/webview_flutter_platform_interface/lib/v4/src/types/load_request_params.dart b/...view_flutter/webview_flutter_platform_interface/lib/v4/src/types/load_request_params.dart
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// TODO(a14n): remove this import once flutter/flutter#104231 lands
+// TODO(a14n): remove this import once Flutter 3.1 or later reaches stable (including flutter/flutter#104231)
 // ignore: unnecessary_import
 import 'dart:typed_data';
 

diff --git a/packages/webview_flutter/webview_flutter_platform_interface/pubspec.yaml b/packages/webview_flutter/webview_flutter_platform_interface/pubspec.yaml
@@ -4,7 +4,7 @@ repository: https://github.com/flutter/plugins/tree/main/packages/webview_flutte
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+webview_flutter%22
 # NOTE: We strongly prefer non-breaking changes, even at the expense of a
 # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes
-version: 1.9.0
+version: 1.9.1
 
 environment:
   sdk: ">=2.12.0 <3.0.0"

diff --git a/packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md b/packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 2.8.1
+
+* Fixes unnecessary imports after [adding some exports of public API in foundation/serialization.dart](https://github.com/flutter/flutter/pull/104231).
+
 ## 2.8.0
 
 * Raises minimum Dart version to 2.17 and Flutter version to 3.0.0.

diff --git a/...view_flutter/webview_flutter_wkwebview/example/integration_test/webview_flutter_test.dart b/...view_flutter/webview_flutter_wkwebview/example/integration_test/webview_flutter_test.dart
@@ -9,7 +9,7 @@
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
-// TODO(a14n): remove this import once flutter/flutter#104231 lands
+// TODO(a14n): remove this import once Flutter 3.1 or later reaches stable (including flutter/flutter#104231)
 // ignore: unnecessary_import
 import 'dart:typed_data';
 

diff --git a/packages/webview_flutter/webview_flutter_wkwebview/lib/src/foundation/foundation.dart b/packages/webview_flutter/webview_flutter_wkwebview/lib/src/foundation/foundation.dart
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// TODO(a14n): remove this import once flutter/flutter#104231 lands
+// TODO(a14n): remove this import once Flutter 3.1 or later reaches stable (including flutter/flutter#104231)
 // ignore: unnecessary_import
 import 'dart:typed_data';
 

diff --git a/packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml b/packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml
@@ -2,7 +2,7 @@ name: webview_flutter_wkwebview
 description: A Flutter plugin that provides a WebView widget based on Apple's WKWebView control.
 repository: https://github.com/flutter/plugins/tree/main/packages/webview_flutter/webview_flutter_wkwebview
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+webview%22
-version: 2.8.0
+version: 2.8.1
 
 environment:
   sdk: ">=2.17.0 <3.0.0"