[google_maps_flutter] Maps snapshot #1719

duzenko · 2019-06-10T14:33:29Z

Description

Implementing the native snapshot() function call.

Related Issues

flutter/flutter#33557

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

No, this is not a breaking change.

# Conflicts: # packages/google_maps_flutter/example/lib/map_ui.dart

…to maps-snapshot

…pshot

iskakaushik · 2019-06-20T00:12:39Z

@duzenko thanks for the PR. We have now added support for on-device tests for google maps plugin. Please take a look at this file for an example test case. I will be happy to help you through any issue you run into while adding tests. Please add some relevant tests to your PR :-)

iskakaushik · 2019-06-20T17:40:39Z

@duzenko one of the issues has been fixed, I will release 0.5.18 soon. For the plugin tools crash, i'm raising it with my team. Looks like stuart is looking into the slow builds issue.

Sorry that you are running into these troubles. Also, thanks for the continued contributions to google maps plugin, really appreciate it.

…pshot

klaszlo8207 · 2020-01-15T17:00:37Z

Any new on this PR?

mtsrdr · 2020-01-23T19:26:38Z

Any progress on this?

packages/google_maps_flutter/example/lib/main.dart

cyanglaz · 2020-01-23T20:55:37Z

@duzenko There seems to be a lot of conflicts. It is hard to review as it is now. Could you rebase?

# Conflicts: # packages/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java # packages/google_maps_flutter/example/lib/map_ui.dart # packages/google_maps_flutter/example/test_driver/google_maps.dart # packages/google_maps_flutter/lib/src/controller.dart

cyanglaz

Thank you for the quick turn-around on rebasing :) This is awesome! The PR looks good overall. I have left some comments and thoughts.
Also, we would need to add some tests to land this new feature.

I would suggest to add an e2e test case to compare screenshot data.

packages/google_maps_flutter/android/gradle.properties

cyanglaz · 2020-01-24T18:45:23Z

packages/google_maps_flutter/example/android/gradle.properties

@@ -1,4 +1,4 @@
-org.gradle.jvmargs=-Xmx1536M
+#org.gradle.jvmargs=-Xmx1536M


packages/google_maps_flutter/example/lib/map_ui.dart

packages/google_maps_flutter/ios/Classes/GoogleMapController.m

packages/google_maps_flutter/lib/src/controller.dart

packages/google_maps_flutter/lib/src/google_map.dart

cyanglaz · 2020-01-24T19:02:53Z

Why does the formatting test fail? I used the plugin tools to format the code before committing.

I assume you use https://github.com/flutter/plugin_tools to format? Try to update the plugin_tool to the latest and reactivate it see if it helps.

cyanglaz · 2020-01-24T19:40:43Z

@duzenko Have you tried to use https://github.com/flutter/plugin_tools to format instead of android studio?

cyanglaz · 2020-01-27T18:59:43Z

@duzenko works for me :) Thanks

cyanglaz · 2020-01-28T18:34:53Z

@duzenko I have formatted the code. Thanks. I will wait on your response to my comments :)

duzenko

Agree to all points

packages/google_maps_flutter/example/lib/map_ui.dart

packages/google_maps_flutter/ios/Classes/GoogleMapController.m

packages/google_maps_flutter/lib/src/controller.dart

packages/google_maps_flutter/lib/src/google_map.dart

packages/google_maps_flutter/example/android/gradle.properties

@@ -1,4 +1,4 @@
-org.gradle.jvmargs=-Xmx1536M
+#org.gradle.jvmargs=-Xmx1536M


fabiorsilva · 2020-02-03T22:37:45Z

Any progress on this?

hinterlandcreative · 2020-02-27T14:23:57Z

Any update on this PR? This is blocking our app release. It looks like this was close to being merged?

CC: @duzenko @cyanglaz

cyanglaz · 2020-03-26T17:17:25Z

This feature is landed with #2607. I'm closing this PR :)

cyanglaz · 2020-03-30T19:58:42Z

@duzenko I apologize not being active with your PR, it was simply because I didn't have much cycle working on this. Your PR is great. And in fact, I think the other PR mentioned your PR in the description as a reference. I landed the other PR simply because it was ready to merge, and we still had some work to do to make this PR ready to merge. I hope that answered your question :)

duzenko added 2 commits June 10, 2019 15:08

[google_maps_flutter] snapshot on android

50d99f8

iOS side + formatting

9cb8757

googlebot added the cla: yes label Jun 10, 2019

duzenko added 6 commits June 10, 2019 18:43

Merge branch 'master' into maps-snapshot

51a499e

# Conflicts: # packages/google_maps_flutter/example/lib/map_ui.dart

Post merge fixes

d4a7b4c

Format

e30a8b6

Analizer appeased

d661056

Merge branch 'maps-snapshot' of https://github.com/duzenko/plugins in…

346dee6

…to maps-snapshot

Merge remote-tracking branch 'upstream/master' into maps-snapshot

fb894e8

duzenko closed this Jun 11, 2019

This comment has been minimized.

Sign in to view

duzenko reopened this Jun 11, 2019

duzenko added 3 commits June 11, 2019 13:58

Merge remote-tracking branch 'upstream/master' into maps-snapshot

0b9963b

Merge branch 'maps-snapshot' of https://github.com/duzenko/plugins in…

b7bd02b

…to maps-snapshot

Check failure blind shooting

c04d235

duzenko mentioned this pull request Jun 11, 2019

Plugins pull requests stopped passing checks after merge with upstream flutter/flutter#34238

Closed

Blind shooting

cfe1f59

duzenko mentioned this pull request Jun 11, 2019

Maps snapshot #1723

Closed

1 task

Reinstate my changes as the checking is seemingly broken

cc16b6d

duzenko changed the title ~~Maps snapshot~~ [[google_maps_flutter] Maps snapshot Jun 13, 2019

duzenko changed the title ~~[[google_maps_flutter] Maps snapshot~~ [google_maps_flutter] Maps snapshot Jun 13, 2019

Merge commit '1e01c9e12d564642735e1a7308a21083b9769b11' into maps-sna…

63a9b25

…pshot

duzenko added 3 commits June 20, 2019 10:45

Merge remote-tracking branch 'upstream/master' into maps-snapshot

ab7d53f

Integration test. Bugfix.

40148ca

Formatting

5b0060a

This comment has been minimized.

Sign in to view

duzenko added 2 commits June 21, 2019 00:40

Muckup revert

ef97946

Merge commit '400bc414afb1e3088ff3c59b841149d1fba1a8e1' into maps-sna…

945e5d5

…pshot

iOS scaling fix

58afa69

iskakaushik added the backlog label Aug 6, 2019

duzenko mentioned this pull request Aug 20, 2019

[google_maps_flutter] Allow (de-)serialization of CameraPosition #1784

Merged

12 tasks

cyanglaz reviewed Jan 23, 2020

View reviewed changes

packages/google_maps_flutter/example/lib/main.dart Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Update main.dart

ec51343

This comment has been minimized.

Sign in to view

cyanglaz reviewed Jan 24, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

formatting

ecc1560

duzenko commented Jan 28, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

miyakeryo mentioned this pull request Mar 14, 2020

[google_maps_flutter] Take snapshot of map #2607

Merged

13 tasks

cyanglaz closed this Mar 26, 2020

This comment has been minimized.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[google_maps_flutter] Maps snapshot #1719

[google_maps_flutter] Maps snapshot #1719

duzenko commented Jun 10, 2019 •

edited

Loading

This comment has been minimized.

iskakaushik commented Jun 20, 2019

This comment has been minimized.

iskakaushik commented Jun 20, 2019

klaszlo8207 commented Jan 15, 2020

mtsrdr commented Jan 23, 2020

This comment has been minimized.

cyanglaz commented Jan 23, 2020

This comment has been minimized.

cyanglaz left a comment

cyanglaz Jan 24, 2020

This comment has been minimized.

cyanglaz commented Jan 24, 2020

This comment has been minimized.

cyanglaz commented Jan 24, 2020

This comment has been minimized.

This comment has been minimized.

cyanglaz commented Jan 27, 2020

This comment has been minimized.

cyanglaz commented Jan 28, 2020

duzenko left a comment

This comment has been minimized.

This comment has been minimized.

fabiorsilva commented Feb 3, 2020

hinterlandcreative commented Feb 27, 2020 •

edited

Loading

cyanglaz commented Mar 26, 2020

This comment has been minimized.

cyanglaz commented Mar 30, 2020

		@@ -1,4 +1,4 @@
		org.gradle.jvmargs=-Xmx1536M
		#org.gradle.jvmargs=-Xmx1536M

[google_maps_flutter] Maps snapshot #1719

[google_maps_flutter] Maps snapshot #1719

Conversation

duzenko commented Jun 10, 2019 • edited Loading

Description

Related Issues

Breaking Change

This comment has been minimized.

iskakaushik commented Jun 20, 2019

This comment has been minimized.

iskakaushik commented Jun 20, 2019

klaszlo8207 commented Jan 15, 2020

mtsrdr commented Jan 23, 2020

This comment has been minimized.

cyanglaz commented Jan 23, 2020

This comment has been minimized.

cyanglaz left a comment

Choose a reason for hiding this comment

cyanglaz Jan 24, 2020

Choose a reason for hiding this comment

This comment has been minimized.

cyanglaz commented Jan 24, 2020

This comment has been minimized.

cyanglaz commented Jan 24, 2020

This comment has been minimized.

This comment has been minimized.

cyanglaz commented Jan 27, 2020

This comment has been minimized.

cyanglaz commented Jan 28, 2020

duzenko left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

fabiorsilva commented Feb 3, 2020

hinterlandcreative commented Feb 27, 2020 • edited Loading

cyanglaz commented Mar 26, 2020

This comment has been minimized.

cyanglaz commented Mar 30, 2020

duzenko commented Jun 10, 2019 •

edited

Loading

hinterlandcreative commented Feb 27, 2020 •

edited

Loading