Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_admob] update AGP, gradle and admob #1942

Closed
wants to merge 6 commits into from
Closed

[firebase_admob] update AGP, gradle and admob #1942

wants to merge 6 commits into from

Conversation

juliocbcotta
Copy link
Contributor

Description

This PR

  • updates AGP, gradle and admob
  • Fix some warnings Android Studio was complaining

Warning example:

  • variable.equals(constant) => constant.equals(variable) to avoid null pointer exception
  • a reference for Activity was being kept global in a class where is was being used only locally, so it was removed.
  • int a = call.argument(constant) => Integer a= call.argument(constant) to remove possible null pointer warning.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@@ -1,3 +1,7 @@
## 0.9.0+4

* Android : Update AGP, gradle and admob.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include the warning removal here in the changelog?

@collinjackson collinjackson added the submit queue The Flutter team is in the process of landing this PR. label Aug 6, 2019
packages/firebase_admob/CHANGELOG.md Outdated Show resolved Hide resolved
packages/firebase_admob/CHANGELOG.md Outdated Show resolved Hide resolved
juliocbcotta and others added 2 commits August 7, 2019 22:43
Co-Authored-By: Collin Jackson <jackson@google.com>
Co-Authored-By: Collin Jackson <jackson@google.com>
@ened
Copy link
Contributor

ened commented Aug 16, 2019

@collinjackson Let's get this merged?

@collinjackson
Copy link
Contributor

Migrated to firebase/flutterfire#34

collinjackson added a commit to collinjackson/flutterfire that referenced this pull request Aug 30, 2019
collinjackson added a commit to firebase/flutterfire that referenced this pull request Aug 30, 2019
* [firebase_admob] update AGP, gradle and admob
* Update CHANGELOG entry with description of #2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes flutterfire submit queue The Flutter team is in the process of landing this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants